Add configuration to be able to mark the link to open in a new window.

Comments

alexismmd created an issue. See original summary.

alexismmd’s picture

StatusFileSize
new1.99 KB
alexismmd’s picture

Issue summary: View changes
anybody’s picture

Version: 8.x-1.3 » 2.0.x-dev
Status: Active » Needs work

Please reroll against 2.0.x-dev.

Furthermore "more_target" isn't a good and self-explaining name for the key. Please change it to more_target_blank for example.

pflora’s picture

Assigned: Unassigned » pflora

I'll work on it!

pflora’s picture

Assigned: pflora » Unassigned
Status: Needs work » Needs review
StatusFileSize
new3.95 KB

I've done a reroll from #2, and added the changes requested by #4. I also corrected some minor CS.

If there is anything that could be improved, feel free to give me any kind of feedback!

Moving this to NR.

alexanderj’s picture

Assigned: Unassigned » alexanderj

Hi, i will review your patch.

alexanderj’s picture

Assigned: alexanderj » Unassigned
Status: Needs review » Reviewed & tested by the community

I reviewed your patch and IMHO your patch is solving all the points mentioned above, so I'm moving to RTBC.

anybody’s picture

Status: Reviewed & tested by the community » Needs work

Could we please have an interdiff from #2 to #6 to see the changes?

ramonvasconcelos’s picture

Assigned: Unassigned » ramonvasconcelos

Okay, gonna make the interdiff.

ramonvasconcelos’s picture

Assigned: ramonvasconcelos » Unassigned
Status: Needs work » Needs review
StatusFileSize
new4.98 KB

Done.

mpaulo’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new3.95 KB
new829 bytes

The use statements had an extra space at the beginning of each line, and had some unused classes. This patch fixes it.

Although manual tests worked, and it looks ok, code-wise, I've changed the default config types to match the other Booleans, just to be more clear.

markie’s picture

Status: Reviewed & tested by the community » Needs review

Lets get some other eyes on your patch before marking it RTBC please.

ramonvasconcelos’s picture

Assigned: Unassigned » ramonvasconcelos

I'll review it.

ramonvasconcelos’s picture

Assigned: ramonvasconcelos » Unassigned
Status: Needs review » Reviewed & tested by the community

The substitutions on the arrays from #12 are correct.

alexismmd’s picture

ultimike’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new7.38 KB

I've re-rolled the patch and made a couple of changes:

  1. I've added a functional test.
  2. I've added the new field to smart_trim.schema.yml
  3. My editor made a few additional minor coding standard fixes.

Needs a quick review before merging.

-mike

ultimike’s picture

StatusFileSize
new7.36 KB

Patch was not applying - re-rolled.

-mike

  • ultimike authored 5ada5ca4 on 2.0.x
    Issue #3193468 by ultimike, mpaulo, alexismmd, pflora: Add config option...
markie’s picture

Reviewed locally and then committed. Sorry, I skipped the RTBC step.

markie’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.