Closed (fixed)
Project:
Smart Trim
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
19 Jan 2021 at 08:26 UTC
Updated:
3 May 2023 at 00:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexismmd commentedComment #3
alexismmd commentedComment #4
anybodyPlease reroll against 2.0.x-dev.
Furthermore "more_target" isn't a good and self-explaining name for the key. Please change it to
more_target_blankfor example.Comment #5
pflora commentedI'll work on it!
Comment #6
pflora commentedI've done a reroll from #2, and added the changes requested by #4. I also corrected some minor CS.
If there is anything that could be improved, feel free to give me any kind of feedback!
Moving this to NR.
Comment #7
alexanderj commentedHi, i will review your patch.
Comment #8
alexanderj commentedI reviewed your patch and IMHO your patch is solving all the points mentioned above, so I'm moving to RTBC.
Comment #9
anybodyCould we please have an interdiff from #2 to #6 to see the changes?
Comment #10
ramonvasconcelos commentedOkay, gonna make the interdiff.
Comment #11
ramonvasconcelos commentedDone.
Comment #12
mpauloThe use statements had an extra space at the beginning of each line, and had some unused classes. This patch fixes it.
Although manual tests worked, and it looks ok, code-wise, I've changed the default config types to match the other Booleans, just to be more clear.
Comment #13
markie commentedLets get some other eyes on your patch before marking it RTBC please.
Comment #14
ramonvasconcelos commentedI'll review it.
Comment #15
ramonvasconcelos commentedThe substitutions on the arrays from #12 are correct.
Comment #16
alexismmd commentedComment #17
ultimikeI've re-rolled the patch and made a couple of changes:
Needs a quick review before merging.
-mike
Comment #18
ultimikePatch was not applying - re-rolled.
-mike
Comment #20
markie commentedReviewed locally and then committed. Sorry, I skipped the RTBC step.
Comment #21
markie commented