Problem/Motivation

  • Add test cases to validate input values while adding an OpenStack cloud service provider
CommentFileSizeAuthor
#6 3193114-6.patch14.52 KBjigish.addweb
#3 3193114-3.patch14.45 KBjigish.addweb

Issue fork cloud-3193114

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb opened merge request !114

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3193114-3.patch14.45 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for adding the validation and test case. Please see my above comments. Thanks

jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3193114-6.patch14.52 KB

@yas

Thank you for your review.

I have done changes as per your comment. Please review the updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for the update. Please see my above comment.

  • yas committed 8c45882 on 3.x authored by jigish.addweb 
    Issue #3193114 by jigish.addweb, yas: Add test cases to validate input...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Fixed

yas closed merge request !114

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.