Submodules need their .info files updated to handle D9. Including a patch from https://www.drupal.org/project/recurly/issues/3109436 by @blakehall to address this.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | recurly-3193071-d9-readiness-5.patch | 10.18 KB | blakehall |
| #4 | recurly-3193071-d9-readiness-4.patch | 8.3 KB | blakehall |
| #2 | 3193071-d9-readiness-2.patch | 857 bytes | mrweiner |
Comments
Comment #2
mrweiner commentedComment #3
eojthebraveLGTM! Would be great to get this committed.
Comment #4
blakehall commentedWe also need to address the entity.manager > entity_type.manager change in order for things to actually work with D9.
Comment #5
blakehall commentedAdding to the patch a missing a parameter in the RecurlyJsFormBase constructor.
Comment #6
eojthebraveThe code here looks good. +1 from me.
Somewhat related; Would be awesome if a maintainer could configure the test suite to run against Drupal 9.x in addition to the current 8.9.x job.
Comment #7
colanEnabled tests for 4.x. Once that's confirmed working, I'm planning to disable the D8 one.
Comment #8
colanNope, ran into #3238416: 4.x branch is failing: Class 'Drupal\simpletest\WebTestBase' not found in modules/recurly_hosted/src/Tests/RecurlyHostedWebTest.php. Any help with that would be appreciated!
Comment #10
colanGot this in because it certainly won't pass without it. I'm going to assume it's fixed for now, but we'll have a better idea once we get the branch passing again. Please reopen if I'm missing something.