Submodules need their .info files updated to handle D9. Including a patch from https://www.drupal.org/project/recurly/issues/3109436 by @blakehall to address this.

Comments

mrweiner created an issue. See original summary.

mrweiner’s picture

Status: Active » Needs review
StatusFileSize
new857 bytes
eojthebrave’s picture

Status: Needs review » Reviewed & tested by the community

LGTM! Would be great to get this committed.

blakehall’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new8.3 KB

We also need to address the entity.manager > entity_type.manager change in order for things to actually work with D9.

blakehall’s picture

StatusFileSize
new10.18 KB

Adding to the patch a missing a parameter in the RecurlyJsFormBase constructor.

eojthebrave’s picture

Status: Needs review » Reviewed & tested by the community

The code here looks good. +1 from me.

Somewhat related; Would be awesome if a maintainer could configure the test suite to run against Drupal 9.x in addition to the current 8.9.x job.

colan’s picture

Version: 8.x-1.x-dev » 4.x-dev

Enabled tests for 4.x. Once that's confirmed working, I'm planning to disable the D8 one.

colan’s picture

  • colan committed 51efc3c on 4.x authored by blakehall
    Issue #3193071 by blakehall, mrweiner, eojthebrave: Added D9 support to...
colan’s picture

Status: Reviewed & tested by the community » Fixed

Got this in because it certainly won't pass without it. I'm going to assume it's fixed for now, but we'll have a better idea once we get the branch passing again. Please reopen if I'm missing something.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.