Submodules need their .info files updated to handle D9. Including a patch from https://www.drupal.org/project/recurly/issues/3109436 by @blakehall to address this.

CommentFileSizeAuthor
#5 recurly-3193071-d9-readiness-5.patch10.18 KBblakehall
#4 recurly-3193071-d9-readiness-4.patch8.3 KBblakehall
#2 3193071-d9-readiness-2.patch857 bytesmrweiner

Comments

mrweiner created an issue. See original summary.

mrweiner’s picture

mrweiner commented
Status: Active » Needs review
StatusFileSize
new 3193071-d9-readiness-2.patch857 bytes
eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Status: Needs review » Reviewed & tested by the community

LGTM! Would be great to get this committed.

blakehall’s picture

blakehall commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new recurly-3193071-d9-readiness-4.patch8.3 KB

We also need to address the entity.manager > entity_type.manager change in order for things to actually work with D9.

blakehall’s picture

blakehall commented
StatusFileSize
new recurly-3193071-d9-readiness-5.patch10.18 KB

Adding to the patch a missing a parameter in the RecurlyJsFormBase constructor.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Status: Needs review » Reviewed & tested by the community

The code here looks good. +1 from me.

Somewhat related; Would be awesome if a maintainer could configure the test suite to run against Drupal 9.x in addition to the current 8.9.x job.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Version: 8.x-1.x-dev » 4.x-dev

Enabled tests for 4.x. Once that's confirmed working, I'm planning to disable the D8 one.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Nope, ran into #3238416: 4.x branch is failing: Class 'Drupal\simpletest\WebTestBase' not found in modules/recurly_hosted/src/Tests/RecurlyHostedWebTest.php. Any help with that would be appreciated!

  • colan committed 51efc3c on 4.x authored by blakehall 
    Issue #3193071 by blakehall, mrweiner, eojthebrave: Added D9 support to...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Got this in because it certainly won't pass without it. I'm going to assume it's fixed for now, but we'll have a better idea once we get the branch passing again. Please reopen if I'm missing something.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.