Problem/Motivation

ValidReferenceConstraintValidator::validate() calls loadUnchanged() on the parent entity every time but it uses this data only if there is an invalid target ID.
This can reduce performances with a slow storage backend and a lot of entity reference fields.

Steps to reproduce

Proposed resolution

Only load the entity if there is an invalid target ID.

Remaining tasks

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#10 drupal-3192591-10.patch1.91 KBprudloff
#8 3192591-nr-bot.txt150 bytesneeds-review-queue-bot
#2 drupal-3192591-2.patch2 KBprudloff

Issue fork drupal-3192591

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff’s picture

prudloff commented
StatusFileSize
new drupal-3192591-2.patch2 KB

The attached patch loads the existing entities only if there an invalid target ID.

prudloff’s picture

prudloff commented
Status: Active » Needs review

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3192591-nr-bot.txt150 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

prudloff’s picture

prudloff commented
StatusFileSize
new drupal-3192591-10.patch1.91 KB

Here is a reroll for Drupal 10.2.3.

prudloff opened merge request !11332

prudloff’s picture

prudloff commented
Status: Needs work » Needs review

Added some tests.

smustgrave’s picture

smustgrave commented
Issue summary: View changes
Issue tags: +Needs Review Queue Initiative

Left a question on the MR, leaving in review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

1 super small feedback, will keep an eye out for it to come back around.

prudloff’s picture

prudloff commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks

  • catch committed bfc9d63d on 11.x 
    Issue #3192591 by prudloff, smustgrave:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

catch closed merge request !11332

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.