The workspace entity type uses string IDs, which prevents it from being moderated by the Content Moderation module, which, at the moment, relies on the content_moderation_state entity type and it uses an integer field for the moderated entity ID.
Ensure that moderation can not be enabled for the workspace entity type by removing its moderation handler.
Review.
Nope.
Nope.
Nope.
Nope.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff_2_6.txt | 1.82 KB | anmolgoyal74 |
| #6 | 3192363-6.patch | 2.35 KB | anmolgoyal74 |
| #6 | 3192363-6-test-only.patch | 1.14 KB | anmolgoyal74 |
| #2 | 3192363.patch | 2.07 KB | amateescu |
| #2 | 3192363-test-only.patch | 1.14 KB | amateescu |
Comments
Comment #2
amateescu commentedThis should do it.
Comment #4
fabianx commentedRTBC - looks great to me.
Comment #5
catchThis looks like the wrong place to do this - although we already do similar for taxonomy terms in taxonomy_entity_type_alter() - we're scattering knowledge about content_moderation around in modules that are altering their own entity definitions, that have already been altered by content moderation.
Can we exclude these in content_moderation itself? I don't think it's possibly to distinguish between integer and string entity type IDs so probably can't auto-detect that.
Comment #6
anmolgoyal74 commentedNot sure if this is expected.
Tried to exclude the workspace entity type in
core/modules/content_moderation/src/EntityTypeInfo.php.Comment #8
amateescu commentedLooks good to me :) Not sure if @catch meant that we should also move the exclusion of taxonomy terms in this issue or in a followup, but let's keep the smaller scope for now.
Comment #12
catchOpened a follow-up for taxonomy #3204883: Move exclusion of taxonomy terms from moderation to content_moderation module.
Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!