Problem/Motivation

taxonomy_entity_type_alter() excludes taxonomy terms from content_moderation.

However this is altering information added by content_moderation module - and taxonomy module doesn't need to know about content_moderation at all. So we could instead exclude taxonomy terms in content_moderation itself.

Steps to reproduce

Proposed resolution

See #3192363: Ensure that moderation can not be enabled for the 'workspace' entity type for existing code in content_moderation doing the same thing for other entity types.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 interddiff_3_5.txt654 bytesanmolgoyal74
#5 3204883-5.patch2.91 KBanmolgoyal74
#3 3204883-3.patch2.91 KBanmolgoyal74
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch created an issue. See original summary.

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Assigned: Unassigned » anmolgoyal74

I'm working on this.

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Assigned: anmolgoyal74 » Unassigned
Status: Active » Needs review
FileSize
3204883-3.patch2.91 KB

Moved exclusion of taxonomy terms from moderation to content_moderation module.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Needs review » Needs work 
// @todo Moderation is disabled for taxonomy terms until integration is
//   enabled for them.
//   @see https://www.drupal.org/project/drupal/issues/3047110

The code indentation for the 3rd line is incorrect.

The first line has 1 space after // and 2nd has 3 ok
The 3rd line should have the save of the 1st one with 1 space, that's right?

Example:

// @todo Moderation is disabled for taxonomy terms until integration is
//   enabled for them.
// @see https://www.drupal.org/project/drupal/issues/3047110
anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
3204883-5.patch2.91 KB
interddiff_3_5.txt654 bytes

Updated indentation.

adalbertov’s picture

adalbertov CreditAttribution: adalbertov at CI&T commented
Status: Needs review » Reviewed & tested by the community

Hello, just checked the patch. The indentation seems to be in order and it work properly, so I'm moving it to RTBC

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 3204883-5.patch, failed testing. View results

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
CreditAttribution: benjifisher at FRUITION commented

Please do not ask the testbot to try again until #3207086: [HEAD BROKEN] Consistent failure in MonthDatePluginTest is fixed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Needs work » Reviewed & tested by the community

#3207086: [HEAD BROKEN] Consistent failure in MonthDatePluginTest is fixed. I have not reviewed the code.

  • catch committed 1ae2680 on 9.2.x 
    Issue #3204883 by anmolgoyal74, catch, RenatoG: Move exclusion of...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 1ae2680 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.