Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
10 Jan 2021 at 16:08 UTC
Updated:
21 Jun 2021 at 11:49 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoComment #3
ntturner commentedLooking pretty good. I had some issues during review/testing:
Bugs/Security
Stylistic Review
ContentTranslationHandlerclass, but the file ConditionalMessageTranslationHandler.php is essentially empty; was this intentional?The bugs/security issues are the main questions/concerns that need to be addressed.
Comment #4
avpadernoI quickly reviewed the code, and I didn't find any evident security issues. I will make a deeper review later.
Comment #5
avpaderno(Sorry: The change of status was a mistake.)
Comment #6
avpadernoI added the PAreview checklist link.
Nothing is reported in that checklist, except the missing tests. While they would help with provided patches, when automatic tests are enabled for the project, they should not be an application blocker (even if they would be an extra point).
Comment #7
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.