Closed (fixed)
Project:
Drupal core
Version:
9.2.x-dev
Component:
Olivero theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Jan 2021 at 16:29 UTC
Updated:
21 May 2021 at 14:29 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
kostyashupenkoAdded some styles. Change for `olivero.theme` was taken from Claro.
Comment #3
mherchelThis is looking great! Needs some additional minor changes, and then I'll post screenshots.
Requested changes are below.
It looks like the
trelement on the selector is unneeded. This can be simplified to.draggable. (this also applies to the other selectors excepta.tabledrag-handle, which needs to be match the specificity of the core stylesheet).Just to keep things consistent, lets use
pxunits here. These will automatically get translated intoremunits via the pxtorem postCSS plugin.use
margin-inline-startfor proper RTL support. Note this will get translated into IE11 compliant CSS by PostCSSI believe the 10px is from the left. Assuming so, we need to add
/* LTR */to the end of this and then create the proper[dir="RTL"]variant.Comment #4
kostyashupenkoComment #5
mherchel#14 looks great! Screenshot attached.
Comment #6
mherchelComment #7
mherchelAdding a picture of how it looks (prior to changes)
Comment #9
benjifisherPlease do not ask the testbot to try again until #3207086: [HEAD BROKEN] Consistent failure in MonthDatePluginTest is fixed.
Comment #10
alexpott#3207086: [HEAD BROKEN] Consistent failure in MonthDatePluginTest is fixed. I have not reviewed the code.
Comment #11
mherchelSetting back to RTBC per #5
Comment #12
lauriiiWhat is this solving?
Nit pick: could we remove the
aelement from the selector?The padding here seems a bit excessive. We would meet the recommendation of 44px touch area with much less padding.
Comment #13
mherchelYeah, seems unrelated and we have another issue for the dropbutton. It's removed.
These selectors are needed to override the tabledrag module's CSS (See screenshot below)
Good catch. Fixed.
Comment #14
proeung@mherchel Patch #13 looks good!
The table sort is looking and working as expected (see attached).
The table select sort is showing an overlapping issue, which is caused by the CSS properties coming from the Webform module (see attached). I believe this is out of scope for this particular issue and might not be something that Olivero should be accounted for, however, I just wanted to quickly note this.
Marking this issue as RTBC +1
Comment #15
lauriiiWe don't necessarily need to add element to the selector to increase specificity to override the CSS, we could do something like
.tabledrag-handle.tabledrag-handlefor example but here it probably doesn't make a huge difference so this is probably good as it is.Comment #16
mherchelGreat catch! Fix added.
Comment #17
mherchelComment #18
mherchelComment #19
gauravvvv commentedWhile checking the table drag, I found an a11y color contrast fail at /admin/structure/block.
After the table drag, the link text color updated to #313637, which results in a fail with bg color: #2494DB.
Adding screenshots for the same.
Comment #20
mherchelThat's a good catch. We can handle the drop-button styling in #3200370: Fix Olivero's drop-button style to conform with new form styles, however.
Comment #21
mherchelTugboat preview for this is at https://3191725-tabledrag-safemtjuagapxqgtrynoasiupl4ahux6.tugboat.qa/
Comment #22
katannshaw commentedJust tested this out on the Tugboat instance at https://3191725-tabledrag-safemtjuagapxqgtrynoasiupl4ahux6.tugboat.qa/ and it worked as expected. I'm marking this as RTBC.
Here's a video recording of me using the tabledrag feature on the Article Form Display form and the Admin Menu form.
Monosnap video: https://monosnap.com/file/JN1v5UilMA9MjAaV6bZ1E819ZCqUsa
Comment #23
lauriiiShould we check with @jwitkowski79 if the designs are acceptable?
I also noticed that the new color rules have a regression with dropbuttons:

Comment #24
jwitkowski79 commented@mherchel reviewed the above with me and it looks good! It has my sign off
Comment #25
lauriii@jwitkowski79 thank you for confirming that the design changes look good for you!
We should still address the regression I mentioned in #23.
Comment #27
mherchel@lauriii I can't seem to find a UI element where I can replicate #23. How do I do this?
Comment #28
mherchelTo answer the question in #27, this can be found in the Taxonomy UI
Patch and interdiff attached.
Comment #29
kristen polI tested a couple things and am including some screenshots:
The taxonomy UI looked okay to me and I was able to drag things fine.
For the manage display page, although dragging works, IMO it seems like:
Comment #30
kristen polIt's hard to tell the sizing in the manage display UI in those screenshots so uploading one more screenshot.
Comment #31
andy-blumMore screen shots from the taxonomy page. I agree that while functional, things look a bit off. That said, Olivero isn't designed as an admin interface and this issue is about the functionality. For that reason +1 RTBC.
Screenshots attached show taxonomy vocab page, dropbutton in action, and re-ordered taxonomy terms
Comment #32
lauriiiI tested table drag in a quick edit. It seems like there are some issues with overflow. Do we want to resolve that here or move that into a follow-up?
Comment #33
mherchelOpened followup #3212814: Quickedit in Tabledrag has overflow
Comment #34
mherchelUpdating issue credits
Comment #37
lauriiiCommitted fac878c and pushed to 9.3.x and 9.2.x. Thanks!