Problem/Motivation

This might originally be a feature rather than a bug, but currently the client secret is always removed from the settings page.
Making it cumbersome to make changes to the page unless you have the secret stored else where or want to retrieve it from the local config file.

I believe the client secret value should be passed to the admin form; I don't see it as a security risk as the form should only be accessible by administrators and the secret can be retrieved from the config just as easily.

Steps to reproduce

  1. Save client secret on /admin/config/system/o365/settings/api
  2. The value will be empty forcing user to re-enter it every time a change is needed.

Current behaviour: Current behaviour

New behaviour: New behaviour

Proposed resolution

The secret should be passed into the admin form simplifying administration.

Remaining tasks

Provide a PR/patch.

CommentFileSizeAuthor
o365-after-update.png20.47 KBcodebymikey
o365-before-update.png16.87 KBcodebymikey

Issue fork o365-3191394

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

codebymikey created an issue. See original summary.

codebymikey opened merge request !2

fabianderijk made their first commit to this issue’s fork.

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Active » Fixed

Thanks for the merge request. This has now been added to the dev release. I will create a new release tag ASAP.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.