Problem/Motivation

ctools $modules property must be declared protected.
See
https://www.drupal.org/node/2909426
6x in DrupalListener::startTest from Drupal\Tests\Listeners

Steps to reproduce

Runs ctools tests

Proposed resolution

Declare $modules property protected

CommentFileSizeAuthor
#8 3191270-8-D9.patch4.83 KBthalles
#3 3191233-2-D9.patch626 bytesthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Follow a patch

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new 3191233-2-D9.patch626 bytes
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Reviewed & tested by the community
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Needs work

Wrong patch?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

I think yes! Sorry!
I will fix this!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new 3191270-8-D9.patch4.83 KB

Here it is a patch for this issue

guilhermevp’s picture

guilhermevp commented
Status: Needs review » Reviewed & tested by the community

Patch works as intended and still applying cleanly.

RTBC!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Added one more and committed it, thank you all!

  • joelpittet committed 2c41294 on 8.x-3.x authored by thalles 
    Issue #3191270 by thalles, joelpittet, guilhermevp: Declare $modules...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Thanks @all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.