We need to add metadata to the document before exporting it to JSON.
Currently, we haven't found a way of doing it, or at least not an "easy" way.
Create an alter hook on ApplenewsManager::getDocumentDataFromEntity to allow modules to alter the document.
Creation of hook_applenews_document_alter
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | issue-3191110-applenews_document_alter.patch | 3.24 KB | betoaveiga |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
betoaveigaComment #3
betoaveigaExcuse me. I uploaded the wrong patch on my previous comment. Re-uploading.
Comment #5
m4oliveiI spoke with @BetoAveiga offline about this the other day.
There is clearly a need to extend the functionality the module provides such that you can customize the Apple News format document before it's sent to Apple News. There are currently other means of doing the same thing that this new hook is intended to do via overriding the
\Drupal\applenews\Normalizer\ApplenewsContentEntityNormalizerservice. The nice thing about that is you get access to the\ChapterThree\AppleNewsAPI\Documentobject to use it's API so your not in the business of ensuring the right JSON formatThat approach has it's downsides as well. Namely it's quite verbose.
I think we can arrive at a middle ground by using an event subscriber embedded in the normalizer stack, which will allow subscribers to affect the
\ChapterThree\AppleNewsAPI\Documentobject.We agreed to go that route. I'm currently working on a patch.
Comment #7
m4oliveiOpened a merge request with some foundation. Refactors a bit for better testability and includes a simple test for the normalizer to make sure I didn't break things. This will be good to build the event subscriber onto.
Comment #8
m4oliveiNeeded to rebase against 8.x-1.x. Fingers crossed for green tests.
Comment #10
m4oliveiYay, green! Also I discussed with @BetoAveiga offline, and he's good with the changes.
Merged to 8.x-1.x.