Problem/Motivation

See \Drupal\migrate\Plugin\migrate\source\SourcePluginBase::count() + \Drupal\migrate\Plugin\migrate\source\SourcePluginBase::$cacheCounts.

This requires #3190815: Source count caching broken: impossible to enable source count caching for SqlBase-based source plugins (plus, unneeded cache I/O) though 😬

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3190980-2.patch618 byteswim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Postponed
StatusFileSize
new 3190980-2.patch618 bytes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] Allow source counts to be cached: implement ::doCount() instead of ::count() » Allow source counts to be cached: implement ::doCount() instead of ::count()
Status: Postponed » Needs review

#3190815: Source count caching broken: impossible to enable source count caching for SqlBase-based source plugins (plus, unneeded cache I/O) landed! 🥳

deaom’s picture

deaom commented

I'm not sure what's happening here, if this patch was meant for some other module or code changed in the meantime. The patch does not apply and looking through code in the PathautoPattern.php file, I do not see a function count, so that is why patch is failing to apply. Will leave status as is, because I'm not sure what's happening.

igork96’s picture

igork96 commented
Status: Needs review » Closed (outdated)

The issue description isn't clear, and yes the related methods do not exist, closing this until further info isn't provided.