This module does not currently supply a simple_block.links.menu.yml file and has no associated administration menu items. I propose adding a menu item under the Block section of the admin menu as shown in the attached image.

CommentFileSizeAuthor
simple-blocks-menu.png44.83 KBkomlenic

Issue fork simple_block-3190913

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

komlenic created an issue. See original summary.

komlenic opened merge request !1

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Postponed (maintainer needs more info)

I don't see why we need this menu link. Isn't there a tab, labeled Simple blocks, on the /admin/structure/block page?

komlenic’s picture

komlenic commented

Correct, there is the tab on the Block Layout page. However, adding this menu link is advantageous in that it:

  • provides a logical menu trail path to the simple block administration
  • prevents an extra click and page load to get to the simple block administration when using Administration Menu
  • is a small config addition that introduces no complexity, security issues, or maintenance overhead

Isn't there a tab, labeled Simple blocks, on the /admin/structure/block page?

By the same logic, the "Block types" and "Custom block library" menu items provided by core don't need to exist, because they too are a tab on the Block Layout page. Based on this convention, it's unexpected UX that Simple Blocks doesn't provide a menu option like the other tabs do, and that was the motivation for this issue and merge request. I think this is a worthwhile addition that addresses UX with no negative consequences. Thanks for your consideration!

komlenic’s picture

komlenic commented
Status: Postponed (maintainer needs more info) » Needs review
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

@komlenic, you're right in #4, my bad. However, unfortunately, block.admin_display route is provided by the block module. But in #3206088: [PP-1] Remove dependency to Block module (may need 2.x) I want to remove the dependency to block module. But where to place the page? No idea.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Reviewed & tested by the community

OK, as this issue is legit and #3206088: [PP-1] Remove dependency to Block module (may need 2.x) needs more research, I'm gonna approve this.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Reviewed & tested by the community » Fixed

Merged, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.