Problem/Motivation

'entity.manager' Service has been deprecated in Drupal 9. Hence the ImagefieldSlideshowFieldFormatter won't work in D9.

Proposed resolution

Use the entity type manager service ('entity_type.manager') instead ...

CommentFileSizeAuthor
#4 interdiff.txt623 bytesravimane23
#4 image_slideshow_ImagefieldSlideshowFieldFormatter_d9_3190617_3.patch6.23 KBravimane23
#2 image_slideshow_ImagefieldSlideshowFieldFormatter_d9_3190617_#2.patch6.22 KBitamair

Comments

itamair created an issue. See original summary.

itamair’s picture

itamair commented
Status: Active » Fixed
StatusFileSize
new image_slideshow_ImagefieldSlideshowFieldFormatter_d9_3190617_#2.patch6.22 KB

The attached patch fixes the issue, more appropriately using the entity type manager service ('entity_type.manager') in the ImagefieldSlideshowFieldFormatter, upgrading the module to Drupal 9 compatibility

It also fixes Drupal/Php Coding standards in the same ImagefieldSlideshowFieldFormatter, correct use of translatable strings and correct use of placeholders into those.

itamair’s picture

itamair commented
Status: Fixed » Needs review
ravimane23’s picture

ravimane23 commented
StatusFileSize
new image_slideshow_ImagefieldSlideshowFieldFormatter_d9_3190617_3.patch6.23 KB
new interdiff.txt623 bytes

Hi @itamair,

You patch is not getting applied to latest dev version, so releasing new patch.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu
Issue tags: +GlobalContributionWeekend2021, +ContributionWeekend2021

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Needs review » Fixed
rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Issue tags: -GlobalContributionWeekend2021

Just doing a little tag tidying. Nice work everyone!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.