Problem/Motivation

  • Refactor the detail view of OpenStack Instance
CommentFileSizeAuthor
#16 3190263-16.patch22.26 KBjigish.addweb
#14 3190263-13.patch20.25 KBjigish.addweb
#12 3190263-12.patch22.87 KBjigish.addweb
#10 3190263-10.patch5.35 KBjigish.addweb
#7 3190263-7.patch5.33 KBjigish.addweb
#5 3190263-5.patch5.36 KBjigish.addweb
#3 3190263-3.patch4.98 KBjigish.addweb

Issue fork cloud-3190263

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb opened merge request !87

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190263-3.patch4.98 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190263-5.patch5.36 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Changing the status to Needs work: Please re-create the patch due to the merge at #3189714.

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190263-7.patch5.33 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

I re-created the patch. Please review the latest patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Please see my above comment.

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190263-10.patch5.35 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

Thank you for your review. Refactored code as per your comments, please review the latest patch.

Thanks

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190263-12.patch22.87 KB

Status: Needs review » Needs work

The last submitted patch, 12: 3190263-12.patch, failed testing. View results

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190263-13.patch20.25 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190263-16.patch22.26 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. I tested the patch and it looks good to me. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed 6416dc2 on 3.x authored by jigish.addweb 
    Issue #3190263 by jigish.addweb, yas: Refactor the detail view of...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !87

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.