I just enabled automated testing for the branch, but we still need tests the existing tests are broken and we could probably add more. Help with this would be appreciated.

Issue fork auto_entitylabel-3190237

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

colan created an issue. See original summary.

timotej-pl made their first commit to this issue’s fork.

timotej-pl opened merge request !2

timotej-pl’s picture

timotej-pl commented
Status: Active » Needs review
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Issue summary: View changes

Thanks for working on this! Does this fix the existing branch failures? I apologize for assuming we didn't have any tests; we did, but they're failing.

If they fix the branch, we can stop waiting for the branch to pass and run anyway. Otherwise, would you kindly include the fixes in your MR?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Priority: Normal » Major

Upgrading priority so that we can get the branch to pass.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Title: Add tests » Fix existing tests and add more

Better title.

DeaOm made their first commit to this issue’s fork.

deaom’s picture

deaom commented

The tests that were added/fixed by @timotej-pl are now passing, once the token module dependency was added. Will leave it as needs review, but I think this can be committed.

deaom’s picture

deaom commented

Because of the defaultTheme changes between 8.9. and 9 and above, test failed on the 9 and above core. After the correction the tests are now passing, still leaving the status to needs review.

  • colan committed 7d2063d on 8.x-3.x authored by timotej-pl 
    Issue #3190237 by DeaOm, timotej-pl: Fix existing tests and add more
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs review » Fixed

Thanks folks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.