The links in level-2 navigation fill the width of the container (the orange outline in the image), but the hover styling is only applied to the span inside the link (the green outline in the image), the width of which is only as wide as the words it contains. The place that this would likely confuse users most is the cursor changes to a pointer when hovering anywhere over the <a>, but the hover style is only applied when the cursor is over text.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3190113-after_patch.gif | 8.8 MB | abhijith s |
| #6 | 3190113-before_patch.gif | 3.1 MB | abhijith s |
| #5 | 3190113-5.patch | 1.14 KB | djsagar |
| #3 | 3190113-3.patch | 709 bytes | djsagar |
| #3 | Before.png | 50.51 KB | djsagar |
Comments
Comment #2
andrewmacpherson commentedRemoving parent. This doesn't have much bearing on accessibility. It's a glitch with the extent of a clickable area, but I don't think there's anything here that puts disabled users at a notable disadvantage.
Comment #3
djsagar commentedHi @bnjmnm,
I created patch as [er your requirement this patch will resolve your issue please review and provide feedback.
Thanks!
Comment #4
bnjmnmGreat @djsagar! It looks like your patch got a "custom commands failed" notice. This is due to directly editing the CSS file instead of compiling the corresponding .pcss.css file and compiling it. Most of us learn of this requirement for the first by seeing this happen to a patch we wrote 🙂
The documentation on developing in Olivero has the info you'll need to contribute CSS (and other!) changes to Olivero.
Comment #5
djsagar commentedHi @bnjmnm,
Thank you for your feedback i recreating patch by using documentation on developing in Olivero please review.
Comment #6
abhijith s commentedApplied patch #5 on 9.1.x and it works fine.Adding screenshots below.
Before patch;
After patch:
RTBC +1
Comment #7
katannshaw commented@djsagar: I've tested patch #5 just as Abhijith S has and it works great. I'm marking it as RTBC and I think that it's ready for review by a maintainer.
Comment #8
mherchelFrom my point of view, the current behavior is the desired behavior. I don't think the underline should span the full width of the submenu.
Because this isn't an accessibility issue (I don't believe it is), I'm going to close as works as designed (unless designers or accessibility folks tell me otherwise).