"title" token doesn't work as expected

I can't reproduce this on the dev branch or 1.15.

I wonder if it's a problem specific to the page title, because there is additional logic tied to how it works?

It seems like it isn't specific to the title. I have same problem for [current-page:metatag:description] and [term:field_metatags:description]

I look at this code

      $tags = metatag_get_default_tags($entity);
      if ($entity instanceof ContentEntityInterface) {
        // If content entity does not have an ID the page is likely an "Add"
        // page, so skip processing for entity which has not been created yet.
        if (!$entity->id()) {
          return NULL;
        }

        $tags += $metatag_manager->tagsFromEntity($entity);
      }

May be we should swap metatag_get_default_tags($entity) with $metatag_manager->tagsFromEntity($entity) block? Because default metatags take precedence over entity's ones now. So if default tag is presented, token get it instead of enity specific.

I added the tests to the previous patch. I haven't much exerience with writing tests yet, so if some more experienced person could take a look at this, it would be great.

Oh, indentation problem, sorry. Fixed

Updated the steps to reproduce to be useful from a fresh Drupal install.

The patch applied correctly and I can confirm that the issue is resolved. Setting a value in the '' tag will trickle down as a token when used in an open-graph title metatag. I tested via Tugboat and updated the test steps within this ticket description.

This change makes sense to me. I would expect overrides to metatags to cascade through the 'general' section into more particular sections like open-graph metatags. But this change should be appropriately documented to inform users of possible regressions which they may not expect.

Code looks good and follows Drupal standards.

Good work, thank you!