Just upgraded from 1.14 to 1.15. Now the token browser doesn't provide Node tokens any more.
Expected behavior: The token browser contains node tokens, just like in 1.14
Actual behavior: No node tokens available.
Using node tokens directly still seems to work.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | metatag-missing-token-types-test-only.patch | 1.35 KB | mortim07 |
| #12 | metatag-missing-token-types.patch | 1.95 KB | mortim07 |
| #8 | metatag-missing-token-types.patch | 1.65 KB | mortim07 |
| #4 | metatag-missing-token-types.patch | 609 bytes | mortim07 |
| #2 | metatag-missing-token-types.patch | 623 bytes | mortim07 |
Comments
Comment #2
mortim07 commentedIt appears there are a few missing lines from MetatagDefaultsForm. The variable $token_types isn't being used, unlike in version 8.x-1.14. I've made a restoration patch.
Comment #3
mortim07 commentedWith reference to the patch. The metatag.token service should be injected in through the constructor. I'll produce another patch with this change.
Comment #4
mortim07 commentedAh, so it appears it was being injected but never used. I've instead changed the patch to reference this service.
Comment #5
mrshowermanNice, patch #4 brings back the node tokens. Thanks @mortim07!
Switching to Needs review so that others have a look.
Comment #6
damienmckennaOh dear, thanks for spotting this and working out some patches.
Any thoughts on adding test coverage for this? I think checking the HTML of the page to confirm the output has the appropriate code to open the token browser would be good.
Comment #7
mortim07 commentedI'll write a functional JS test for it.
Comment #8
mortim07 commentedAdded functional JS test.
Comment #9
mortim07 commentedComment #10
mortim07 commentedWoops, forgot docs.
Comment #12
mortim07 commentedComment #13
damienmckennaComment #14
damienmckennaWould you mind uploading a tests-only patch to confirm the problem? Thank you.
Comment #15
mortim07 commentedSure thing!
Comment #17
mortim07 commentedComment #18
bwaindwain commentedpatch #12 works good for me
Comment #19
finex commentedComment #20
damienmckennachefkiss.gif
Thank you mortim07! I'll try to get this, and a few other small fixes, out in a new release this week.
Comment #21
damienmckenna@FiNeX: Please be careful to add your comment to the comment field and avoid erasing the existing issue summary contents.
Comment #23
damienmckennaCommitted. Thank you.
Comment #24
finex commented@DamienMcKenna sorry, I've filled the wrong textarea :-)
Comment #25
gregglesTime for a new release to get this into the world?
Comment #26
pavelculacov commentedThis patch is missing in 1.15
Comment #27
damienmckennaThe patch wasn't committed before 1.15 was released, it'll be in the new 1.16.
Comment #29
eiriksmThanks to everyone involved in fixing the issue, and even adding tests (removed the "needs tests" tag).
Just wanted to politely nudge that more people are interested in a new release including this fix ✌️