This is exactly the same as #3105925: The description of the arguments for FieldDefinition::setDisplayOptions() conflicts with what reported in FieldDefinitionInterface::getDisplayOptions(), but for BaseFieldDefintion instead of FieldDefinition. The docblock of BaseFieldDefinition::setDisplayOptions wasn't updated either in #2796581: Fields must store their region in entity displays, so it still mentions setting type='hidden' instead of region='hidden'.

CommentFileSizeAuthor
#13 3188327-13.patch933 byteslongwave
#9 3188327-9.patch826 bytesravi.shankar
#6 Screenshot from 2022-01-18 10-19-29.png26.22 KBvikashsoni
#3 Screenshot-from-2020-12-16.jpg40.29 KBranjith_kumar_k_u
#2 3188327-2-basefielddefinition-region-hidden.patch818 bytesDeFr

Comments

DeFr created an issue. See original summary.

DeFr’s picture

DeFr commented
Status: Active » Needs review
StatusFileSize
new 3188327-2-basefielddefinition-region-hidden.patch818 bytes
ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new Screenshot-from-2020-12-16.jpg40.29 KB

The above patch works as expected .it corrects the documentation mistake.
after patch

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni commented
StatusFileSize
new Screenshot from 2022-01-18 10-19-29.png26.22 KB

Applied patch #2 in drupal-9.3.x-dev
Applied successfully and after patch documentation mistake has been updated
Thanks for the Patch

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thank you @DeFr - 'region' is the correct key.

@ranjith_kumar_k_u, @vikashsoni please note there is no need to attach screenshots of patches being applied, the testbot automatically applies patches and will report back if they fail.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

Sorry, the changed line is not wrapped correctly.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3188327-9.patch826 bytes

Addressed comment #8.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mjpa’s picture

mjpa commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, moving this on... 18 months for a documentation fix :(

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

Still not wrapped correctly :(

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3188327-13.patch933 bytes
mjpa’s picture

mjpa commented
Status: Needs review » Reviewed & tested by the community

How did I miss that... #9 needed work, #13 is good...

  • catch committed 70c8d13 on 10.0.x 
    Issue #3188327 by DeFr, longwave, ravi.shankar, quietone: Docblock of...
  • catch committed 0e2da42 on 10.1.x
    Issue #3188327 by DeFr, longwave, ravi.shankar, quietone: Docblock of...
  • catch committed 7275b2a on 9.4.x
    Issue #3188327 by DeFr, longwave, ravi.shankar, quietone: Docblock of...
  • catch committed 4f5ad33 on 9.5.x
    Issue #3188327 by DeFr, longwave, ravi.shankar, quietone: Docblock of...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, cherry-picked back through to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.