Problem/Motivation

A time service was added to 8.3.x in #2717207: Add a time service to provide consistent interaction with time()/microtime() and superglobals.

Core code should be updated to remove deprecated uses of REQUEST_TIME and time() and others.

For more informations, see the change record.

Proposed resolution

Splitting this up into manageable chunks (#57 by @mpdonadio)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#13 eu_cookie_compliance-parent_constructor-3188207-13.patch1.68 KBmaximpodorov
#5 3188207-5.patch2.24 KBPooja Ganjage
#3 eu_cookie_compliance_replace_time_with_service-3188207-1.patch625 bytesandrewsizz

Comments

AndrewsizZ created an issue. See original summary.

andrewsizz’s picture

andrewsizz commented
Parent issue: » #2902895: [meta][no patch] Replace uses of REQUEST_TIME and time() with time service
andrewsizz’s picture

andrewsizz commented
Status: Active » Needs review
StatusFileSize
new eu_cookie_compliance_replace_time_with_service-3188207-1.patch625 bytes

Status: Needs review » Needs work

The last submitted patch, 3: eu_cookie_compliance_replace_time_with_service-3188207-1.patch, failed testing. View results

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3188207-5.patch2.24 KB

Hi,

Creating a patch for injecting time service.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: 3188207-5.patch, failed testing. View results

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
svenryen’s picture

svenryen commented
Status: Needs review » Reviewed & tested by the community

Tested - thanks for the patch!

  • svenryen committed 43122f5 on 8.x-1.x 
    Issue #3188207 by AndrewsizZ, Pooja Ganjage, svenryen: Replace uses of...
svenryen’s picture

svenryen commented
Status: Reviewed & tested by the community » Fixed

Merged.

maximpodorov’s picture

maximpodorov commented
Status: Fixed » Needs work

Parent constructor call is incorrect (4 arguments are required).

maximpodorov’s picture

maximpodorov commented
Status: Needs work » Needs review
StatusFileSize
new eu_cookie_compliance-parent_constructor-3188207-13.patch1.68 KB

Status: Needs review » Needs work

The last submitted patch, 13: eu_cookie_compliance-parent_constructor-3188207-13.patch, failed testing. View results

svenryen’s picture

svenryen commented
Status: Needs work » Needs review

  • svenryen committed 9dd6abe on 8.x-1.x 
    Issue #3188207 by AndrewsizZ, Pooja Ganjage, maximpodorov, svenryen:...
svenryen’s picture

svenryen commented
Status: Needs review » Fixed

Added - thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.