Olivero - Update blocks machine name to be prefixed by the theme machine name [#3187899]

Problem/Motivation

When placing block on a page, you can set the block machine name. But the configuration of this block depends on the theme you place your block in.

On the same websites, if there are multiple themes, you can't place the same block on another theme with the same machine name because it is already used.

Proposed resolution

Replace blocks machine name, for example:

block.block.book_navigation.yml => block.block.olivero_book_navigation.yml
block.block.primary_admin_actions.yml => block.block.olivero_primary_admin_actions.yml

Remaining tasks

Make a patch
Review

Comment	File	Size	Author
#11	3187899-11.patch	2.17 KB	ameymudras
#3	Capture d’écran de 2020-12-11 15-57-27.png	125.93 KB	grimreaper
#3	Capture d’écran de 2020-12-11 15-57-16.png	194.6 KB	grimreaper
#3	Capture d’écran de 2020-12-11 15-57-11.png	182.16 KB	grimreaper

Issue fork drupal-3187899

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3187899-olivero---update

changes, plain diff MR !134

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

11 December 2020 at 14:43

Grimreaper created an issue. See original summary.

Comment #2

11 December 2020 at 14:58

Grimreaper opened merge request !134

Comment #3

grimreaper

French

France 🇫🇷

commented 11 December 2020 at 15:01

Status:

Active

» Needs review

Status	File	Size
new	Capture d’écran de 2020-12-11 15-57-11.png	182.16 KB
new	Capture d’écran de 2020-12-11 15-57-16.png	194.6 KB
new	Capture d’écran de 2020-12-11 15-57-27.png	125.93 KB

I have tested and the two concerned blocks are not affected by the machine name renaming.

See attached screenshots.

Comment #4

11 December 2020 at 15:01

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #5

xjm

she/her

English

commented 20 August 2021 at 03:45

Issue summary:	View changes
Issue tags:		+Needs upgrade path, +Needs upgrade path tests

Edit: Disregard earlier comment; this is default config.

Comment #6

xjm

she/her

English

commented 20 August 2021 at 03:47

Issue tags:

-Needs upgrade path, -Needs upgrade path tests

Comment #7

20 August 2021 at 03:47

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #8

20 August 2021 at 03:47

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.