No "Drupal" in UI text -- views, views_ui

I added "+1"s to the MR comments I agreed with, so there's a couple small changes I think we have mini-consensus on. (As much as you can have a consensus among 4 people.)

Hi I'm Joseph
I'm at DrupalCon's mentored contribution sprint and I'm testing this patch

I installed this on Simplytest.me, the patch worked just fine
Looks good to me

Line 164 of the form field description has the word Drupal in it.
/www/web/core/modules/views_ui/src/Form/BasicSettingsForm.php

Tagging for DrupalCon Prague

Hi I'm Andrew
I'm at DrupalCon Prague's mentored contribution sprint and I'm working on this issue

I searched with RegEx for "Drupal" Occurences in t-Functions ([ >]t\(["'].*Drupal.*["']\)).
The only occurence I can find (excluding classes and variables) is at core/modules/views/src/Plugin/views/field/FieldPluginBase.php line 1007:

$this->t('This can be an internal path such as node/add or an external URL such as "https://www.drupal.org". You may use the "Replacement patterns" above.')

The instance reported in comment #12 was fixed in commit 3ff1303e.
I have searched the codebase and found no further instances of the word Drupal.

Replace Drupal with the Site as per #12 and not sure to replace drupal.org external path as per #15, would like to hear from the community members. Thanks

@dabley, Made changes as per comment #18 needs review .

I've taken a quick look at the patches in #17 and and #20. The patch in #17 provides the changes to a single string and the patch #20 just adds a second string. But both patches miss all changes already made in MR142?

about the actual changes in#17. The sentence sounds incomplete. I wonder would it make sense to add an article and change the beginning of the string from Site has the potential to run... to The site has the potential to run...?

and i agree with #18. the external link to drupal.org hasn't to be replaced necessarily nevertheless i consider the suggested replacement with example.com the cleaner clearer approach.

about the actual changes in #20. The patch provides the suggested changes in #18 by changing the url from drupal.org to example.com but misses the changes for the actual string proposed in #15. the term Drupal path is still used. Both suggestions from #15 and #18 applied would lead to This can be an internal path such as node/add or an external URL such as "https://www.example.com". You may use the "Replacement patterns" above.

@rkoller, Made changes as per the comment #21 needs review.

thank you. the two strings in question i've summarized in #21 look good to me. but all the changes from merge request 142 (https://git.drupalcode.org/project/drupal/-/merge_requests/142.diff) are still missing in the patch. committing the changes to the merge request, where the main work was done so far, might be still the best choice. or the other way around add the changes from merge request to the patch.

@rkoller
Thank you for notifying around.
Have added the changes from merge request patch of 142 and as per the comment #21 needs review.

Hi, Observed few more changes where we need to replace Drupal to in the patch and updating new patch against 10.1.x.

Looks like the changes from the MR are included. From what I can tell everything has been covered.

Thanks for moving this forward!

The Issue Summary states that the task here is to remove 'Drupal' from UI text, as does the title. However, the patch is changing code comments. The out of scope changes need to be removed.

Also, this is changing text in Views which displays lots of text and options. I don't think it makes sense to have screenshots of every change, but perhaps for some. This does need manual testing to make sure that all the text is displayed correct and is correct English.

Removed the comment changes.

Wasn't sure about @ViewsQuery() but left them as is.

Reviewing the text changes makes sense to me. Though will admit I thought "Drupal" made more sense in some places.

Leaving the manual testing as there are several places to check.

In regards of your question about viewsquery, I agree that the current state sounds a bit off without Drupal (the proposed change misses the context which database API is actually used) . Maybe it would make sense to mind the suggested pattern from the proposed resolutions section in the issue summary?

Currently the string is changed to Query will be generated and run using the database API in #31 but why not change it to something like
Query will be generated and run using the core softwares database API instead. I am only puzzled what the correct possessive form for softwares would be? softwares', software's, or just softwares? not a native speaker and i am uncertain about that detail all the time :/

Sounds like there is more work to be done.

I think using just the word software can be used in plural also?

According to this english stackexchange comment not necessarily: https://english.stackexchange.com/a/210926/20461. But from my understanding, in the context of the sentence in question, it sounds like a singular noun? And with the noun software being singular i would suggest going with an apostrophe: Query will be generated and run using the core software's database API? (https://www.sussex.ac.uk/informatics/punctuation/apostrophe/possessives).

and will take a closer look at the rest of the strings tomorrow again.

Re-Roll The patch As per suggestion #32 to #34.

I have reviewed and applied the patch and it works perfect for 10.1.x.

Doing cleanups like this on a per-module basis is explicitly prohibited by the core issue scope guidelines. See #2144861-31: [meta] Replace Drupal in UI text with the name of the distribution for more information. Thanks!