Problem/Motivation

Article schema can include an Organization / Person but sub_properties for the latter don't include a Description.

Steps to reproduce

Enable Article schema for a content type and add an Organization / Person.

Proposed resolution

Add a description sub property for Organization (inherited by Person when included as child schema).
Would this be a case of adding a description item to src/Plugin/schema_metatag/PropertyType/Organization.php.

CommentFileSizeAuthor
#4 description-sub-property-for-organization-or-person-3187882-4.patch810 bytesioanmar

Issue fork schema_metatag-3187882

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

weborion created an issue. See original summary.

ioanmar’s picture

ioanmar commented
Issue summary: View changes
ioanmar’s picture

ioanmar commented
Title: Description sub_property for Person » Description sub_property for Organization / Person
ioanmar’s picture

ioanmar commented
StatusFileSize
new description-sub-property-for-organization-or-person-3187882-4.patch810 bytes

Attaching a patch that adds a description to the Organization class.

ioanmar’s picture

ioanmar commented
Status: Active » Needs work
ioanmar’s picture

ioanmar commented
Status: Needs work » Needs review
ioanmar’s picture

ioanmar commented

@DamienMcKenna @wells is it possible to have some feedback here please?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 8.x-2.x-dev » 3.0.x-dev
Status: Needs review » Needs work

Thank you for putting this together.

With a quick look I think this is the correct approach.

Due to drupalci being shut down, this needs to be turned into a merge request for the 3.0.x branch, then we can confirm whether it still works.

ioanmar’s picture

ioanmar commented

Thanks for your uber-quick response and good to hear!
Ah yes, I'll prepare a MR :)

ankitv18 made their first commit to this issue’s fork.

ankitv18 opened merge request !69

ankitv18’s picture

ankitv18 commented

@ioanmar I've created a MR on your behalf please do check/validate and update if need.

cc: @DamienMcKenna

ioanmar’s picture

ioanmar commented

@ankitv18 very speedy indeed but not sure why you ignored my last comment?
Just saw your last comment, thanks anyway but kinda double effort :)

ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

@ioanmar Oops I'm sorry but your effort isn't in the vein. I saw it's unassigned and thought you would need more time.
Always happy to help!!

Btw pipelines are passing for all ~~ hence moving into review.

cc: @DamienMcKenna

ioanmar’s picture

ioanmar commented

Yes my bad I should’ve assigned it. Thanks for tip (and speed)!

ankitv18’s picture

ankitv18 commented

Hi @ioanmar, Could you please validate and review the same changes at your end? And marked this one RTBC so we could take this ahead.

ioanmar’s picture

ioanmar commented
Status: Needs review » Reviewed & tested by the community

Looks good & works as expected, moving to RTBC.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3368793: Plan for Schema Metatag 3.1.0

Thank you both for finishing this off.

I think this needs to go into a 3.1.x release.

ioanmar’s picture

ioanmar commented

Thank You!

anybody made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 3.0.x-dev » 3.1.x-dev
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • anybody committed 3615c351 on 3.1.x authored by ankitv18 
    Issue #3187882 "Description subproperty for organization or person."

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.