The main page lists under dependencies: "Database logging is a Core (optional) module," implying that the Role Watchdog module sends such notices to the PSR-3 log formerly known as Watchdog. However, the Drupal 8.x version does not do this.

CommentFileSizeAuthor
#10 interdiff_7_10.txt272 bytesericgsmith
#10 role_watchdog-3187778-10.patch4.24 KBericgsmith
#8 role_watchdog-3187778-4-7-interdiff.txt2.83 KBrosk0
#8 role_watchdog-3187778-7.patch4.25 KBrosk0
#4 3187778-4.patch3.44 KBgaurav.kapoor
#2 role_watchdog-watchdog.patch3.35 KBjohn franklin

Issue fork role_watchdog-3187778

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

John Franklin created an issue. See original summary.

john franklin’s picture

john franklin commented
Status: Active » Needs review
StatusFileSize
new role_watchdog-watchdog.patch3.35 KB

Patch attached (re)adds the functionality.

gaurav.kapoor’s picture

gaurav.kapoor commented
Assigned: Unassigned » gaurav.kapoor
Category: Bug report » Feature request
Status: Needs review » Needs work

Thanks for adding this feature, but the patch doesn't apply anymore.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs work » Needs review
StatusFileSize
new 3187778-4.patch3.44 KB

Modified the patch a lil bit and did a re roll as well.

gaurav.kapoor’s picture

gaurav.kapoor commented
Assigned: gaurav.kapoor » Unassigned
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Needs work

This patch will also require an update hook to update settings for websites in which this module is already installed.

gaurav.kapoor’s picture

gaurav.kapoor commented

Reference code for adding update hook https://gist.github.com/mikecrittenden/2d2c6734c506d509505fa79142125757

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Status: Needs work » Needs review
StatusFileSize
new role_watchdog-3187778-7.patch4.25 KB
new role_watchdog-3187778-4-7-interdiff.txt2.83 KB

Thank you for the patch improvement @gaurav.kapoor. In future, when updating a patch, can you please supply interdiff to simplify a review process.

Attached is an updated patch, with inderdiff.

Changes:

  • Added schema for new configuration option - nullable to avoid updating existing websites and changing behaviour
  • Simplified default configuration value assignment in the configuration form
  • Simplified configuration check in the role_watchdog_user_update()
gaurav.kapoor’s picture

gaurav.kapoor commented
Version: 8.x-1.x-dev » 2.0.x-dev

Let's target this with the 2.0.x development release.

ericgsmith’s picture

ericgsmith commented
StatusFileSize
new role_watchdog-3187778-10.patch4.24 KB
new interdiff_7_10.txt272 bytes

We have been using the patch in #8 for a long time and it works as expected.

Adding a minor nitpick - boolean value should be lowercase in installed config.

ericgsmith opened merge request !7

  • ericgsmith committed 0b164de3 on 2.x 
    Issue #3187778 by ericgsmith, RoSk0, gaurav.kapoor, John Franklin:...
ericgsmith’s picture

ericgsmith commented
Version: 2.0.x-dev » 2.x-dev
Status: Needs review » Fixed

Added patch 10 to MR and additional minor PHPCS fixes - thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.