Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
I am noticing two issues with our footer navigations links currently.
- The links have some padding applied, especially on the left side is problematic, because that makes it miasligned with the content.
- The links could be displayed inline with flex, so that we end up saving vertical space.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3186903-improve-footer-links-5.patch | 1019 bytes | pivica |
Comments
Comment #2
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedHere is the patch with the proposed changes.
Comment #3
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedThis patch fails to apply to our projects because of https://www.drupal.org/files/issues/2020-05-18/3137537-footer-margin-com.... Adding the patch on top of that.
Comment #4
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedSeems like there was also a conflict with this patch https://www.drupal.org/files/issues/2020-05-18/3137671-generalize-link-c....
The following patch is on top of both #3137537 and #3137671.
Comment #5
pivica CreditAttribution: pivica at MD Systems GmbH commentedI agree that horizontal padding looks weird and it is breaking the grid. I've created a proposal for additional refactoring improvements in #3220586: Menus should use Bootstrap nav/nav-link only for horizontal menus in header region, but these changes are a bit too much for 1.x version so we will move it to 2.x.
Here is a new patch against the latest dev. I've just reset horizontal padding for footer content nav links with respect to the navigation link hover underline animation option. Note that this is done for all screen sizes because often you want to show the title for that block links in the footer and then it again looks weird and it is not following a grid.
I've removed the other change like displaying links in a row for small screens. This is quite specific for now and i didn't saw too many examples of this, or I am wrong? Anyway this kind of improvements we can discuss in #3220586: Menus should use Bootstrap nav/nav-link only for horizontal menus in header region.
Comment #7
pivica CreditAttribution: pivica at MD Systems GmbH commentedCommitted.