The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
Fix the "Project" functionalities (2) resource limit (Pod Count = 0)
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3186692-10.patch | 3.3 KB | xiaohua guan |
Issue fork cloud-3186692
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3186692-fix-the-project-resource-limit-pod-count
changes, plain diff MR !46
Comments
Comment #3
xiaohua guan commented@yas
Please review the patch file. Thanks.
FYI, it seems that k8s doesn't support the case that pod count is 0, so I changed the min value of field_pod_count to 1.
Comment #4
yas@xiaohua-guan
Thank you for the refactoring. It looks good to me. I'll merge the patch to
8.x-2.xand3.xand close this issue asFixed.Comment #7
yasComment #9
yas@xiaohua-guan
Please let us re-open this issue since we have a test error like: https://www.drupal.org/pift-ci-job/1906398
We need to add some code to take care of the case of
Pod Count = 0in the test case since $this->createProjectTestFormData returns$add[]['field_pod_count[0][value]'] = 0or$edit[]['field_pod_count[0][value]'] = 0as a random value (random_int(0, 20)).When
$add[]['field_pod_count[0][value]'] = 0or$edit[]['field_pod_count[0][value]'] = 0, it displays an error message:Pod count must be higher than or equal to 1.Therefore we need to add the assertion when
$add[]['field_pod_count[0][value]'] = 0or$edit[]['field_pod_count[0][value]'] = 0.Comment #10
xiaohua guan commentedComment #11
xiaohua guan commentedComment #13
xiaohua guan commented@yas
Please review the patch file. Thanks.
Comment #14
yas@xiaohua-guan
Thank you for fixing the issue. I reviewed the patch and it looks good. I'll merge the patch to
8.x-2.xand3.xand close this issue asFixed.Comment #17
yas