Problem/Motivation

Fix the "Project" functionalities (2) resource limit (Pod Count = 0)

CommentFileSizeAuthor
#10 3186692-10.patch3.3 KBxiaohua guan

Issue fork cloud-3186692

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

Status: Active » Needs review

@yas

Please review the patch file. Thanks.

FYI, it seems that k8s doesn't support the case that pod count is 0, so I changed the min value of field_pod_count to 1.

yas’s picture

Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the refactoring. It looks good to me. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 293b2b1 on 8.x-2.x authored by Xiaohua Guan
    Issue #3186692 by Xiaohua Guan, yas: Fix the K8s Project functionalities...

  • yas committed ecea659 on 3.x authored by Xiaohua Guan
    Issue #3186692 by Xiaohua Guan, yas: Fix the K8s Project functionalities...
yas’s picture

Status: Reviewed & tested by the community » Fixed

yas’s picture

Status: Fixed » Needs work

@xiaohua-guan

Please let us re-open this issue since we have a test error like: https://www.drupal.org/pift-ci-job/1906398

We need to add some code to take care of the case of Pod Count = 0 in the test case since $this->createProjectTestFormData returns $add[]['field_pod_count[0][value]'] = 0 or $edit[]['field_pod_count[0][value]'] = 0 as a random value (random_int(0, 20)).

When $add[]['field_pod_count[0][value]'] = 0 or $edit[]['field_pod_count[0][value]'] = 0, it displays an error message: Pod count must be higher than or equal to 1.

Therefore we need to add the assertion when $add[]['field_pod_count[0][value]'] = 0 or $edit[]['field_pod_count[0][value]'] = 0.

xiaohua guan’s picture

StatusFileSize
new3.3 KB
xiaohua guan’s picture

Status: Needs work » Needs review

xiaohua guan’s picture

@yas

Please review the patch file. Thanks.

yas’s picture

Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for fixing the issue. I reviewed the patch and it looks good. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed fc905fc on 8.x-2.x authored by Xiaohua Guan
    Issue #3186692 by Xiaohua Guan, yas: Hotfix - Fix the K8s Project...

  • yas committed 5dcedc5 on 3.x authored by Xiaohua Guan
    Issue #3186692 by Xiaohua Guan, yas: Hotfix - Fix the K8s Project...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.