Problem/Motivation

Revert the revert PHP56 polyfill removal that is breaking tests and not needed for D8
https://www.drupal.org/docs/system-requirements/php-requirements

commit eb9d2ec730d143e443cc16012fbf2a6f9d064973
Author: Hendrik Grahl <hendrik@grahl.ch>
Date:   Fri Nov 13 00:54:55 2020 +0100

    Revert "Remove unnecessary polyfill."

    This reverts commit 2eaa1a941bf13634dbda5369511e8816202abd50.

Steps to reproduce

Proposed resolution

Remove + "symfony/polyfill-php56": "~1.8",

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ldap-3186630

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joelpittet created an issue. See original summary.

joelpittet opened merge request !7

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review

Here's the branch failures this should fix:
https://www.drupal.org/pift-ci-job/1882082

2) Drupal\Tests\ldap_authentication\Kernel\LoginTest::testWhiteListPresent
Error: Class 'Symfony\Polyfill\Php56\Php56' not found

  • grahl committed 314d0df on 8.x-4.x 
    Issue #3186630: Fix branch test failures
grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Needs review » Fixed

Thanks for the input.

The solution wasn't usable since it only removed the polyfill (which wasn't available for 7.4 anymore) but didn't provide an alternative for cases where ldap_escape isn't available, which is the case for drupal.org CI where the LDAP extension is missing.

I've reluctantly copied the code over from the polyfill and added it to our trait to be able to test the behavior and still not rely on the extension there since it doesn't like that will ever become available.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Thanks! I didn’t dig deep enough to find why it was there to start

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.