Problem/Motivation

  • Implement OpenStackService to use OpenStack native API for Snapshots List and Operations
CommentFileSizeAuthor
#23 3186025-23.patch106.71 KBjigish.addweb
#22 3186025-22.patch108.1 KBjigish.addweb
#20 3186025-20.patch106.54 KBjigish.addweb
#19 3186025-19.patch106.94 KBjigish.addweb
#17 3186025-17.patch104.86 KBjigish.addweb
#15 3186025-15.patch102.49 KBjigish.addweb
#12 3186025-12.patch103.34 KBjigish.addweb
#10 3186025-10.patch103.92 KBjigish.addweb
#7 3186025-7.patch101.48 KBjigish.addweb
#4 3186025-4.patch126.63 KByas

Issue fork cloud-3186025

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb opened merge request !39

jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new 3186025-4.patch126.63 KB

@jigishaddweb

Thank you for the update. I commented in your MR.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3186025-7.patch101.48 KB

@yas

Please review the latest patch.

Thanks

jigish.addweb’s picture

jigish.addweb commented
Title: implement OpenStackService to use OpenStack native API (Snapshots) (List and Operations) » Implement OpenStackService to use OpenStack native API (Snapshots) (List and Operations)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Implement OpenStackService to use OpenStack native API (Snapshots) (List and Operations) » Implement OpenStackService to use OpenStack native API (Volumes and Snapshots) (List and Operations)
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3186025-10.patch103.92 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for the update. I tested the patch and it worked as expected. I posted my comment at MR (showing above comments).

Thanks

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3186025-12.patch103.34 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

I refactored the code. Please review the latest patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Please review my unresolved comments above. Note that there some unresolved issues in my comment at #10

Thanks,

jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3186025-15.patch102.49 KB

@yas

I refactored the code as per your latest comment.

Please review.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3186025-17.patch104.86 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3186025-19.patch106.94 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3186025-20.patch106.54 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3186025-22.patch108.1 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3186025-23.patch106.71 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

I changed the logic as per your suggestion.

Please review the latest patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. I re-tested the patch and it looks perfect now. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed b664bdb on 3.x authored by jigish.addweb 
    Issue #3186025 by jigish.addweb, yas: Implement OpenStackService to use...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !39

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.