Problem/Motivation

There are multiple instances where comments are ending with a double period.
core/lib/Drupal/Component/PhpStorage/FileStorage.php
core/lib/Drupal/Core/Cache/Context/CacheContextsManager.php
core/lib/Drupal/Core/Routing/AccessAwareRouterInterface.php
core/modules/contact/tests/src/Functional/ContactSitewideTest.php
core/modules/system/tests/src/Functional/Form/ElementTest.php
core/lib/Drupal/Core/Routing/StackedRouteMatchInterface.php
core/modules/field/src/FieldStorageConfigInterface.php
core/modules/migrate/src/Row.php
core/modules/user/src/UserInterface.php

CommentFileSizeAuthor
#2 3185657-2.patch5.59 KBpameeela

Comments

anmolgoyal74 created an issue. See original summary.

pameeela’s picture

pameeela commented
Status: Active » Needs review
Issue tags: +Bug Smash Initiative
StatusFileSize
new 3185657-2.patch5.59 KB

Patch attached for the listed instances, I have not checked whether there are any others though.

sulfikar_s’s picture

sulfikar_s commented
Status: Needs review » Reviewed & tested by the community

Hello, Tested the patch in #2 and it applied cleanly. It properly removes all the comments ending with a double period (..) of files mentioned in the description.

Saw some random failures in the tests. Otherwise good to go with the patch!

Changing the status to RTBC!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs review

Is this something that could be handled by cspell?

anmolgoyal74’s picture

anmolgoyal74 commented

I'm not sure if this can be handled with cspell.
we have many different scenarios like this 

   * @param string ...
   *   Keys to be searched for.
   *

   * @code
   * [
   *   'visible' => [
   *     JQUERY_SELECTOR => REMOTE_CONDITIONS,
   *     JQUERY_SELECTOR => REMOTE_CONDITIONS,
   *     ...
   *   ],
   * ]
   * @endcode
   * All conditions must be met for the state to be applied.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Category: Bug report » Task
Status: Needs review » Postponed
Issue tags: +Coding standards

I've been learning about coding standards and this falls into that category which makes this a task not a bug and adding tag. Then, a sniff is needed to detect these and then they will be fixed.

An issue needs to be opened in Coding standards project.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Postponed » Closed (duplicate)

This was fixed in #3486996: Fix extra periods at the end of comment lines. Closing as a duplicate

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.