Cache Register aims to improve the developer experience of caching arbitrary data. It does this by providing simple Drawer, Slot, and Register objects that enforce best practice naming of associated cache entries and provide assorted helper methods for interacting with those cache entries. Sample implementation code and additional under the hood details available on the module page.

The module has full-ish test coverage that's passing on both D8 and D9.

Manual Reviews of Other Projects

Project link

https://www.drupal.org/project/cache_register

Git instructions

git clone --branch 1.0.x https://git.drupalcode.org/project/cache_register.git

PAreview checklist

http://pareview.net/r/40

Comments

mrweiner created an issue. See original summary.

mrweiner’s picture

mrweiner commented
Issue summary: View changes
mrweiner’s picture

mrweiner commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

Thank you for applying! None of those two reviews are manual reviews, since they only show a tool output.

mrweiner’s picture

mrweiner commented
Issue summary: View changes
mrweiner’s picture

mrweiner commented
Issue summary: View changes
mrweiner’s picture

mrweiner commented

@kiamlaluno sorry about that! New around here so I misunderstood the reqs for manual review. I've added links for 3 new manual reviews that I think should qualify.

mrweiner’s picture

mrweiner commented
Issue tags: +PAreview: review bonus

Forgot to add the tag after updating manual reviews

mrweiner’s picture

mrweiner commented
Priority: Normal » Critical

Per https://www.drupal.org/node/539608

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Priority: Critical » Normal
Status: Needs review » Needs work

I added the PAreview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAreview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

mrweiner’s picture

mrweiner commented
Status: Needs work » Needs review

PAreview has false positives for working branch (it's already set up on a version branch) and for the most of the sniffs (they are seeing {@inheritdoc} lines as problematic when they are not -- obviously they shouldn't be capitalized or end in a full stop). There are line length issues in the README that I can address but I don't think that should be a blocker for approval.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.