Problem/Motivation

When updating from 1.x to 2.x on a site, the site is broken. This is because the 2.x version adds message and message_notify as dependencies, but these are not enabled as part of the update process.

Steps to reproduce

  1. Install a fresh Drupal site
  2. Add Private Message 1.x (including install)
  3. Update code to Private Message to 2.x (make sure message and message_notify are also added to the site)
  4. Run database updates
  5. Visit the site

Proposed resolution

Add an update hook enabling the new dependencies.

Remaining tasks

  • Create patch
  • Review
  • Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork private_message-3184550

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eelkeblok created an issue. See original summary.

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Issue summary: View changes
eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Issue summary: View changes

Fix typos.

tbsiqueira made their first commit to this issue’s fork.

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Status: Active » Needs review
Related issues: +#3029461: Move message notification system to a submodule

Fixed here: https://www.drupal.org/project/private_message/issues/3029461

My steps:

Case 1:
- install 1.x
- update to 2.x
- error

Case 2
- install 1.x
- update to the version in MR of issue 3029461
- no error (as service moved to submodule)

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Issue tags: +LutskGCW22
artem_sylchuk’s picture

artem_sylchuk
Primary language Ukrainian
Location Lutsk
commented
Version: 8.x-2.x-dev » 3.0.x-dev
Status: Needs review » Fixed

As long as #3029461: Move message notification system to a submodule is a breaking change (updates the public interfaces) it was merged into the 3.x branch.
So formally there'll be no 1.x to 2.x update, you'll need to switch directly to 3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.