This is a follow up from this issue https://www.drupal.org/project/shariff/issues/3129454 to apply the patch provided by @rwam to fix:

but the submitted patch leads to the following notice now:

Notice: Undefined index: shariff_default_settings in _shariff_get_settings() (line 144 of /…/modules/contrib/shariff/shariff.module

Using isset() solves this for me. See attached patch.

CommentFileSizeAuthor
#5 3184255-php-notice-5.patch597 bytesmathilde_dumond
#5 3184255-interdiff-2-5.txt604 bytesmathilde_dumond
#2 3184255-1-php-notice.patch598 bytesmathilde_dumond

Comments

mathilde_dumond created an issue. See original summary.

mathilde_dumond’s picture

mathilde_dumond commented
StatusFileSize
new 3184255-1-php-notice.patch598 bytes
johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/shariff.module
@@ -141,7 +141,7 @@ function _shariff_get_settings($blocksettings = NULL) {
 
-  if ($blocksettings && !$blocksettings['shariff_default_settings']) {
+  if ($blocksettings && !isset($blocksettings['shariff_default_settings'])) {
     // block specific settings are active.
     $services = $blocksettings['shariff_services'];

I'm not sure if !isset() is the same thing, what are the possible values of shariff_default_settings.

Both TRUE and FALSE would evaluate to FALSE here, only NULL would be TRUE.

empty() might make more sense here, FALSE/0/NULL/'' would all result in TRUE while basically any other value would be FALSE.

mathilde_dumond’s picture

mathilde_dumond commented
StatusFileSize
new 3184255-interdiff-2-5.txt604 bytes
new 3184255-php-notice-5.patch597 bytes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

granik credited GLOBAL 2000.

granik’s picture

granik
he/him
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.