Since IEF now requires at least Drupal 8.8 we can remove InlineEntityFormTestBase::waitForElementRemoved and replace it with $assert_session->waitForElementRemoved as described in the @todo in the docblock of InlineEntityFormTestBase::waitForElementRemoved

Issue fork inline_entity_form-3183937

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !1

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3190705: Inconsistency in composer.json and inline_entity_form.info.yml

Soft-pinging @geek-merlin worked in the past... ;)

Seriously: This seems like a trivial change, since the code in the removed InlineEntityFormTestBase::waitForElementRemoved was a copy of $assert_session->waitForElementRemoved and the latest release of IEF (8.x-1.0-rc8) now requires at least Drupal 8.8 (https://git.drupalcode.org/project/inline_entity_form/-/blob/8.x-1.0-rc8... and https://git.drupalcode.org/project/inline_entity_form/-/blob/8.x-1.0-rc8...)

Hmmm, seems like we have an inconsistency in composer.json and inline_entity_form.info.yml...
Created #3190705: Inconsistency in composer.json and inline_entity_form.info.yml to fix that.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

I LOVE cleaanup!

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

So the other commit triggered testbot, let's confidentially wait for them.

spokje’s picture

spokje
Primary language Dutch
commented

Patch still green after #3190705: Inconsistency in composer.json and inline_entity_form.info.yml was committed.
Tips hat @geek-merlin

So the other commit triggered testbot,

That just might have be me triggering...😇

  • geek-merlin committed 52d28cc on 8.x-1.x authored by Spokje 
    Issue #3183937 by Spokje, geek-merlin: Replace InlineEntityFormTestBase...
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs review » Fixed

Still green so merged. Thanx!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

@Spokje: SoftPing... Can you PM me on this please please?