Problem/Motivation

The \Drupal\Tests\permissions_by_entity\Kernel\EntityPublicationTest test is missing an @group annotation in its docblock.

This causes a Drupal\Core\Test\Exception\MissingGroupException: Missing @group annotation in Drupal\Tests\permissions_by_entity\Kernel\EntityPublicationTest in Drupal\Core\Test\TestDiscovery::getTestInfo() (line 356 of core/lib/Drupal/Core/Test/TestDiscovery.php). error when Drupal\simpletest\TestDiscovery->getTestClasses() (Line: 157) runs.

Steps to reproduce

  1. Download Drupal 8.9.9, this module, and all its dependencies.
  2. Install with the Standard install profile, enable this module, enable simpletest module
  3. Go to /admin/config/development/testing:
    • Expected result: See a list of tests to run, one of which is the aforementioned EntityPublicationTest
    • Actual result: See a WSOD. If debugging is enabled, see the aforementioned MissingGroupException

Proposed resolution

Add a group annotation.

Remaining tasks

  1. Write a patch - done by @mparker17 in #2; turned into MR by @vitaliyb98 in #4
  2. Review and feedback - done by @vitaliyb98 before #5
  3. RTBC and feedback - done by @vitaliyb98 before #5
  4. Commit - done by @vitaliyb98 before #7
  5. Release

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 3183555-2--entitypublicationtest-missing-group-annotation.patch899 bytesmparker17

Issue fork permissions_by_term-3183555

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mparker17 created an issue. See original summary.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3183555-2--entitypublicationtest-missing-group-annotation.patch899 bytes

Here's a patch. Reviews welcome.

vitaliyb98 made their first commit to this issue’s fork.

vitaliyb98 opened merge request !67

vitaliyb98’s picture

vitaliyb98 commented
Status: Needs review » Fixed

Committed and pushed to 3.1.x-dev Thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • vitaliyb98 committed aaa5c8d4 on 3.1.x-dev 
    Issue #3183555 by mparker17, vitaliyb98: EntityPublicationTest missing @...
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Awesome, thanks @vitaliyb98!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.