Problem/Motivation

On pressing escape key the entity browser modal popup does not close, While with the core media library as a widget this behaviour is working fine.

Steps to reproduce

  • Enable media module
  • Add a field of type media in article content type
  • Install and enable entity browser module
  • Add an entity browser by navigating to admin/config/content/entity_browser/add as image browser with all default settings
  • Navigate to article >> form display and select entity browser as widget for the media field that you have created
  • Now go to add article form and click a select entities or image a modal popup will open
  • Now press escape key it won't close
CommentFileSizeAuthor
#6 afterFix.mov1.93 MBdivya.sejekan
#5 3183414-4854c20620950e32562404f178f8bf9a61ebb1dd-03.patch1.07 KBabhinesh
#2 3183414-2.patch642 bytesarshadkhan35

Issue fork entity_browser-3183414

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arshadkhan35 created an issue. See original summary.

arshadkhan35’s picture

arshadkhan35 CreditAttribution: arshadkhan35 as a volunteer commented
Status: Active » Needs review
FileSize
3183414-2.patch642 bytes

Patch for the same.

abhinesh made their first commit to this issue’s fork.

abhinesh opened merge request !46

abhinesh’s picture

abhinesh
Primary language English
CreditAttribution: abhinesh as a volunteer commented
Version: 8.x-2.5 » 8.x-2.10
Assigned: Unassigned » abhinesh
FileSize
3183414-4854c20620950e32562404f178f8bf9a61ebb1dd-03.patch1.07 KB

I have added the patch re-roll for version 8.x-2.10.

divya.sejekan’s picture

divya.sejekan CreditAttribution: divya.sejekan at QED42 for Drupal India Association commented
Assigned: abhinesh » Unassigned
FileSize
afterFix.mov1.93 MB

Verified using patch #5 . The issue is fixed and used is able to close the entity browser by esc key.

Testing steps :
- Enable media module
- Add a field of type media in article content type
- Install and enable entity browser module
- Add an entity browser by navigating to admin/config/content/entity_browser/add as image browser with all default settings
- Navigate to article >> form display and select entity browser as widget for the media field that you have created
- Now go to add article form and click a select entities or image a modal popup will open
- Now press escape key it won't close

Keeping the issue in Need review since the MR has some issues