This module provides integration between Esendex SMS Gateway and SMS Framework module.
Maintainers of this module are not affiliated with the Esendex Group.

Project link

https://www.drupal.org/project/sms_esendex

Git instructions

git clone --branch 7.x-1.x https://git.drupalcode.org/project/sms_esendex.git

Comments

sluc23 created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +PAreview: project created less than ten days ago
mrweiner’s picture

mrweiner commented
Status: Needs review » Needs work

Some standards violations from phpcs

FILE: /app/web/modules/contrib/sms_esendex/drush/sms_esendex.drush.inc
------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] You must use "/**" style comments for a file comment
24 | ERROR | [x] Doc comment short description must end with a full stop
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: /app/web/modules/contrib/sms_esendex/drush/sms_esendex.drush.inc
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------
2 | WARNING | There must be no blank line following an inline comment
-----------------------------------------------------------------------

mrweiner’s picture

mrweiner commented
Status: Needs work » Needs review

Sorry, just took a look through https://groups.drupal.org/node/427683 and the above doesn't warrant Needs Work.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
sluc23’s picture

sluc23 commented

@mrweiner phpcs errors are fixed now in branch 7.x-1.x-dev
https://git.drupalcode.org/project/sms_esendex/-/tree/7.x-1.x-dev

sluc23’s picture

sluc23 commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -PAreview: project created less than ten days ago
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.