Problem/Motivation

For Drupal 9 Compatibility, the fnmatch function should be removed, as stated by the Upgrade Status Message.

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 93   Calls to function fnmatch should not exist.
--------------------------------------------------------------------------------
Check manually 122  Calls to function fnmatch should not exist.
--------------------------------------------------------------------------------

Proposed resolution

Proposing to change the fnmatch to a preg_match, that will follow a comparison string that mimics the functionality of fnmatch.

CommentFileSizeAuthor
#3 3182849-3.patch1.78 KBbircher
#2 config_ignore-3182849-2.patch1.27 KBcozydrupalnerd

Issue fork config_ignore-3182849

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ZeiferDev created an issue. See original summary.

cozydrupalnerd’s picture

cozydrupalnerd commented
StatusFileSize
new config_ignore-3182849-2.patch1.27 KB

Here is the proposed patch.

bircher’s picture

bircher
Location 🇨🇿
commented
Status: Active » Needs review
StatusFileSize
new 3182849-3.patch1.78 KB

how abut we just copy paste the method that does the same on 3.x

  • bircher committed 88559f6 on 8.x-2.x 
    Issue #3182849 by ZeiferDev, bircher: Drupal 9 fnmatch function fix
bircher’s picture

bircher
Location 🇨🇿
commented
Status: Needs review » Fixed

Thanks for opening the issue and the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hmdnawaz made their first commit to this issue’s fork.