Needs review
Project:
Password Reset Landing Page (PRLP)
Version:
2.0.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Nov 2020 at 20:54 UTC
Updated:
10 May 2026 at 17:01 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
pawelgorski87 commentedPatch add validator from password_policy module, also included https://www.drupal.org/files/issues/2020-08-25/prlp-form_validation-3143...
Comment #3
pawelgorski87 commentedComment #4
pawelgorski87 commentedComment #5
jasonawantAdding related issue #2943105: Password policy and Password Reset Landing Page. I haven't had a chance to compare this solution to that one.
Comment #6
jasonawantAlso, I'm wondering if additional logic is needed to replicate _password_policy_user_profile_form_submit() setting the user account's field_last_password_reset value.
Otherwise, after a user resets their password, they could still have an expired password which prompts them to reset their password yet again.
See _password_policy_user_profile_form_submit()
Comment #7
adriancidThe patch needs reroll
Comment #10
mably commentedThis simple MR adds two events (replacement for hooks) to allow other modules to take actions on password validation and before password save.
Once this MR is applied you can integrate PRLP with Password Policy by using this module: https://www.drupal.org/project/password_policy_extras (Link to the related EventSubscriber class).
Thanks for merging!
Comment #11
mably commentedComment #15
mably commentedI have moved my MR to its own dedicated issue to make things clearer.
Comment #16
mably commentedComment #17
ccrawford91 commentedPostponing for now.
Issue #3447787 added events and dispatches them so that other modules can listen for and respond accordingly themselves.
Comment #18
anybodyhttps://www.drupal.org/project/prlp/issues/3447787 is merged, setting this back to active.
Also see https://www.drupal.org/project/password_policy_extras - is that a viable solution?
Comment #19
ccrawford91 commentedThe password policy extras module is the only viable option at present. The password policy module doesn't perform its checks unless you're on the "user.reset" route. The reset form exists on the "user.reset.form" route so the password policy service does nothing.
The password policy module either needs to expand its "valid" routes to include the form one or subscribe to the events the prlp module provides (which is what the extras' submodule is already doing).
Comment #20
anybody@ccrawford91 would it maybe make sense to integrate https://www.drupal.org/project/password_policy_extras into prlp directly or as submodule to make it more visible?
At least I think it should be made visible on the module page of prlp and in the README?
Comment #21
anybodyComment #22
ccrawford91 commented@anybody After looking at how the policy extras module works, I've written a similar submodule in the prlp module.
Take a look and try out this branch.
Comment #24
ccrawford91 commented