Problem/Motivation

After updating this module from 7.x-1.15 to 7.x-1.17, the 'more' link on Views content pane displays no longer shows up:

Also, exposed filters in a block on a page other than the views page do not work -- using the exposed form does not take you to the views page as it should.

These are both caused by the change in #2242375: Attach feeds to a views pane. In that issue Content pane displays are said to always have a path. But due to an issue in Views, 'more' links are not supported for displays that have a path, even if you can configure one: #1427854: "More link" option should have configurable target for views page displays.

Steps to reproduce

  1. Create a number of nodes.
  2. Create a view with a Page display and a Content pane display.
  3. On the Content pane display, configure to show only a specified number of items (for example: 3 items).
  4. On the Content pane display, on 'More link' enable options 'Create more link' and 'Display 'more' link only if there is more content'.
  5. Render the Content pane display.

Expected result
When there are more than 3 results, a more link should be shown.

Actual result
No more link gets shown.

Proposed resolution

Revert the change from #2242375: Attach feeds to a views pane and add test coverage for rendering the 'more' link.

Remaining tasks

  1. Review
  2. Commit
  3. Reopen #2242375: Attach feeds to a views pane

User interface changes

API changes

Data model changes

A patch with tests will follow.

CommentFileSizeAuthor
#4 interdiff-3179884-2-4.txt1.07 KBmegachriz
#4 ctools-migrate-support-3179884-4.patch8.34 KBmegachriz
#2 ctools-views-content-pane-more-link-3181701.patch8.21 KBmegachriz
#2 ctools-views-content-pane-more-link-3181701-tests-only.patch7.61 KBmegachriz
content-pane-more-link.png85.65 KBmegachriz

Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented
Assigned: megachriz » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new ctools-views-content-pane-more-link-3181701-tests-only.patch7.61 KB
new ctools-views-content-pane-more-link-3181701.patch8.21 KB

The tests only patch should fail.

The last submitted patch, 2: ctools-views-content-pane-more-link-3181701-tests-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new ctools-migrate-support-3179884-4.patch8.34 KB
new interdiff-3179884-2-4.txt1.07 KB

Code style fixes.

cliddell’s picture

cliddell commented
Version: 7.x-1.16 » 7.x-1.17
Status: Needs review » Reviewed & tested by the community

Testing Notes:

  1. Installed:
    • Drupal 7.73
    • ctools 7.x-1.17
    • views 7.x-3.24
    • panels 7.x-3.10
    • panelizer 7.x-3.4
  2. Created 3 articles.
  3. Created a view for displaying the articles with a Page display and a Content pane display.
  4. Configured the Content pane display to only show 2 items.
  5. Enabled the settings "Create more link" and "Display 'more' link only if there is more content" on the Content pane display.
  6. Added the Content pane display to a new custom page.
  7. Navigated to the custom page.
  8. The more link showed up, however it pointed to the Edit custom view > Content pane display page for both logged in and anonymous users.
  9. Applied the patch from comment #4.
  10. The more link began working properly pointing to the page view with all 3 articles.

RTBC

freelock’s picture

freelock
Location Seattle
commented
Issue summary: View changes

This issue also affects exposed filters set to be a block, and placed on a different page.

Without the patch, using exposed filters on a page different from the view, you get returned to the page you are on, with no view results.

With this patch, the correct behavior is restored -- using exposed filters takes you to the corresponding view page, and you get filtered results. This worked up until 7.x-1.6.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-1.17 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed
Parent issue: » #3178697: Plan for CTools 7.x-1.18 release

Thank you very much @MegaChriz for the tests and steps to reproduce and all who helped. I've committed this to dev for the next release.

  • joelpittet committed 727ead9 on 7.x-1.x authored by MegaChriz 
    Issue #3181701 by MegaChriz, cliddell, freelock: 'More' link in Content...
megachriz’s picture

megachriz
Primary language Dutch
commented

@joelpittet
Thanks for committing! You may want to reopen #2242375: Attach feeds to a views pane, because the changes in that issue were reverted by this one.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.