Izi Message is a very simple module that provides Drupal messages.

Project link

https://drupal.org/project/izi_message

Git instructions

git clone --branch '2.x' https://git.drupalcode.org/project/izi_message.git

Comments

UsingSession created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: [D8||9] Izi Message » [D8] Izi Message
Assigned: usingsession » Unassigned
Issue summary: View changes

Thank you for applying! Remember to change status, when the project is ready to be reviewed, as this issue queue uses the current status to tell reviewers not to review, yet, the project.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Closed (won't fix)

I am closing this application due to lack of replies.

usingsession’s picture

usingsession commented
Status: Closed (won't fix) » Active

@apaderno, sorry for the lack of answers. I working on the project.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Remember to change status, when the project is ready to be reviewed, as this issue queue uses the current status to tell reviewers not to review, yet, the project.

司南’s picture

司南 commented
Status: Active » Needs review

The issue status should be Need Review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Active

The user who applies can keep the status to Active, if the project is not yet ready to be reviewed.

usingsession’s picture

usingsession commented
Title: [D8] Izi Message » [D9] Izi Message
Issue summary: View changes
Status: Active » Needs review

In module version 2, short:

  1. Remove plugin system
  2. Add more izi toast options
  3. Remove library from module folder

In previous versions, creating a plugin system was a terrible decision. So I decided to delete it.
The library was also removed from the module and the configuration form was expanded

Why didn't I think about migration, it's just that this module is used by a couple of people, and the module does not contain a very important configuration

Why only Drupal 9 ? Because: "The Drupal 8 EOL date is November 2nd 2021"

pareview.net - does not work, so the link is missing 🙃

usingsession’s picture

usingsession commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs review » Needs work

9.x-dev is the wrong name for a branch, and 9.x should be 2.x, basing on the project page. Both the branch needs to be removed; the correct branch needs to be created and made the default one.

usingsession’s picture

usingsession commented
Issue summary: View changes
Status: Needs work » Needs review

Thanks @apaderno, I removed 9.x and 9.x-dev branches - https://git.drupalcode.org/project/izi_message/-/branches, and set 2.x as default.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
  • What follows is a quick review of the project; it doesn't mean to be complete
  • For every point, the review doesn't make a complete list of lines that should be fixed, but an example of what is wrong in the code
  • A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; if a point isn't about that, it makes it clear
class IziMessage extends StatusMessages {

The Drupal classes that implement specific plugins aren't part of the public API and cannot be used as parent class for a class implemented by third-party modules. It's also not necessary to implement a #pre_render callback.

usingsession’s picture

usingsession commented
Status: Needs work » Needs review

@apaderno, ok thanks. Changed - Removed: "extends StatusMessages", and also removed #pre_render

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.