Do not register Phar stream wrapper on PHP 8 because it is not vulnerable to unserialize bugs

@Pooja Ganjage that's not the fix here. We can't remove the dependency - we still support PHP 7.3.

IN \Drupal\Core\DrupalKernel::boot() we only need to do this when on PHP 7.

    if (in_array('phar', stream_get_wrappers(), TRUE)) {
      // Set up a stream wrapper to handle insecurities due to PHP's builtin
      // phar stream wrapper. This is not registered as a regular stream wrapper
      // to prevent \Drupal\Core\File\FileSystem::validScheme() treating "phar"
      // as a valid scheme.
      try {
        $behavior = new PharStreamWrapperBehavior();
        PharStreamWrapperManager::initialize(
          $behavior->withAssertion(new PharExtensionInterceptor())
        );
      }
      catch (\LogicException $e) {
        // Continue if the PharStreamWrapperManager is already initialized. For
        // example, this occurs during a module install.
        // @see \Drupal\Core\Extension\ModuleInstaller::install()
      }
      stream_wrapper_unregister('phar');
      stream_wrapper_register('phar', PharStreamWrapper::class);
    }

@andypost can you explain a bit more re #7.

@andypost I think in #15 you meant to say... It does not throw exception on PHP >= 8 ... it certainly does throw an exception on PHP < 8.

+++ b/core/tests/Drupal/KernelTests/Core/File/PharWrapperTest.php
@@ -24,10 +24,13 @@ public function testPharFile() {
+    // @todo clean-up for PHP 8.0+ https://www.drupal.org/node/3210486
+    if (PHP_VERSION_ID < 80000) {
+      // Ensure that file operations via the phar:// stream wrapper throw an
+      // exception for files without the .phar extension.
+      $this->expectException('TYPO3\PharStreamWrapper\Exception');
+      file_exists("phar://$base/image-2.jpg/index.php");
+    }

What does happen with the regular phar handler in PHP 8 with files that are not phar files?

Committed and pushed 1a7b7f7219b to 10.0.x and 1311b624e7e to 9.4.x. Thanks!

Can we get a follow-up to remove the dependency and code on Drupal 10? Thanks!