Closed (fixed)
Project:
Juicebox HTML5 Responsive Image Galleries
Version:
8.x-3.0-alpha2
Component:
Code
Priority:
Major
Category:
Support request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Nov 2020 at 18:34 UTC
Updated:
12 Nov 2021 at 21:48 UTC
Jump to comment: Most recent
Comments
Comment #2
fkelly12054@gmail.com commentedGood question. The two most relevant issue threads are:
https://www.drupal.org/project/juicebox/issues/3042821
(Drupal 9 Deprecated Code Report) which culminates in
https://www.drupal.org/pift-ci-job/1780708
where it appears that there is a fix to the tests required by Drupal. Unfortunately, while the technical coding issues with the tests (or some of them) may have been resolved there is no explanation. I believe there was an October 9 commit to 8.x-2.x that fixed some (or all) of the obsolete test issues. But that's not clear.
There is also:
https://www.drupal.org/project/juicebox/issues/3150320
Drop Libraries Dependency where we appear to have reached a resolution that will allow us to remove the dependency on the contrib library module. This has resulted in an agreement to create a new "branch" 8.x-3.x that should then be the base to build a Drupal 9 version of the code. (having the contrib library dependency was a blocker for moving forward with Drupal 9).
I have tested the fixes proposed in 3150320 locally and @Neslee has come up with a patch that will apply them. That's most of what will go in 8.x-3.x (I think) but it's going to require more thorough testing than I am able to generate locally ... I don't use all the Juicebox features personally and don't pretend that I can do all the testing that's needed. I'm guessing we'll need to run the 8.x-3.x code through all the automated Drupal 9 code testing programs to see if further changes are needed.
Comment #3
D4K0 commentedComment #4
neslee canil pintoMade a alpha release for drupal 9 version, please test - https://www.drupal.org/project/juicebox/releases/8.x-3.0-alpha1
Comment #5
neslee canil pintoComment #6
lpsolit commented3.0-alpha1 cannot be installed on Drupal 9.1.0:
Drupal\Core\Extension\InfoParserException : The 'core_version_requirement' constraint (9.1.0) requires the 'core' key not be set in temporary://update-extraction-92f31f6f/juicebox/tests/modules/juicebox_mimic_article/juicebox_mimic_article.info.yml in Drupal\Core\Extension\InfoParserDynamic->parse()
This line must go away from *.info.yml:
core: 8.x
Comment #7
fkelly12054@gmail.com commentedActually I think that we need is an added line so the file reads:
I think that in testing we didn't run a full installation with all the test files. I don't have access to commit this.
Actually ... you could help us test this by making the change I suggested above and trying the install again. Let us know if this works or if you find any other blockers just edit the file and put the core_version_requirement line in.
Comment #8
neslee canil pintoTagged new release https://www.drupal.org/project/juicebox/releases/8.x-3.0-alpha2 which solves #6
Comment #9
neslee canil pintoComment #10
lpsolit commentedI played with alpha2 a bit and everything works fine, on both Drupal 8.9 and 9.1. I think you can safely promote it to beta quality for a wider audience.
Comment #12
bill_redman commentedHi, I know this issue was marked closed and it's almost a year old but I just upgraded a site to Drupal 9.2.8 with Juicebox 8.x-3.0-alpha2 and I am getting the message
The Juicebox Javascript library does not appear to be installed. Please download and install the most recent version of the Juicebox library.My reading of this thread and others was that alpha1 resolved this issue. Am I mistaken?
Thanks.
Comment #13
fkelly12054@gmail.com commentedThe issue should be resolved with alpha2. With that release Juicebox detects the library internally (within the Juicebox code) rather than relying a the contrib library module.
the juicebox.js file should be installed
either within sites/all/libraries/juicebox
or within /libraries/juicebox
For what it's worth, it can be in both places without causing problems. The code looks in sites/all/libraries first because that's the "legacy" location for it. I have about 125 Juicebox albums working properly on my site with Drupal 9.2.8.
You do want the alpha2 version of Juicebox.
I just noticed that the main project page, under the title Dependencies, says: "Before installing this module please download and install the required Drupal Libraries API module version 2.0 or above via http://drupal.org/project/libraries"
This program is not needed with Juicebox alpha2. We removed the need for it in the Fall of 2020 when it was not clear if the Drupal Libraries API module would ever be updated for Drupal 9. (I just noticed that the libraries api module had a new release in October 2021). It should not interfere with Juicebox's built in detection. But if you are still having problems and you have that installed we may need to look further.
Not being a maintainer I can't reopen this issue but I will check back. I did change the version to alpha2.
Comment #14
bill_redman commentedThanks @fkelly for your reply. It appears I did misinterpret what I was reading. I had concluded that the juicebox.js file and the libraries folder was no longer needed. No wonder I was getting that message.
I installed the library as indicated and all is well now. Thanks again.
Comment #15
fkelly12054@gmail.com commentedGood to hear that @Bill Redman. I guess I can just leave this as closed and people will find it if they need to.
I am pushing separately to get the tests fixed so we can update the version of Juicebox we are using. So far as I can tell, in nearly a year with the alpha2 release we haven't encountered any show stopping bugs that would keep people from viewing their albums.
There are still a lot of little niggling issues in the code where it doesn't conform to Drupal standards or uses deprecated functions. We're working on it.