Problem/Motivation

When configuring a view and edit options in the dialog options that appear if chosen is triggered, the results are hidden.

Steps to reproduce

1. Create view. (/admin/structure/views/add)
2. Enter an some dummy text to get edit screen. (e.g. /admin/structure/views/view/test_view)
3. Open the permission selection screen, under access => view published content - Twice (chosen not loaded first time)
4. Note that the results are cut off.

ISSUE:

SOLUTION:

Proposed resolution

Detect if chosen is trigged in a Drupal dialog box, if so, resize the dialog on open/close event.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 3179785-9.patch960 bytesnagy.balint
#6 3179785-5.patch998 bytesdrupatz
#5 3179785-5.patch990 bytessilverham
#4 3179785-4.patch1.17 KBsilverham
#2 3179785-show-solution.png33.57 KBsilverham
#2 3179785-show-problem.png14.69 KBsilverham
#2 3179785-2.patch1.19 KBsilverham

Issue fork chosen-3179785

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

silverham created an issue. See original summary.

silverham’s picture

silverham commented
Status: Active » Needs review
StatusFileSize
new 3179785-2.patch1.19 KB
new 3179785-show-problem.png14.69 KB
new 3179785-show-solution.png33.57 KB
silverham’s picture

silverham commented
Issue summary: View changes
silverham’s picture

silverham commented
StatusFileSize
new 3179785-4.patch1.17 KB

Remove console.log().

silverham’s picture

silverham commented
StatusFileSize
new 3179785-5.patch990 bytes

Less changes to other line + filter to only parents #drupal-modal

drupatz’s picture

drupatz commented
StatusFileSize
new 3179785-5.patch998 bytes

Fixed the patch for Drupal 9.5.10

Nebel54 made their first commit to this issue’s fork.

nebel54’s picture

nebel54
Primary language German
Location Vienna
commented
Status: Needs review » Reviewed & tested by the community

Patch #5 works like a charm. Thanks for that!

Personally I would have stored the reference to the chosen drop element in a variable instead of using jQuery a second time to find it, but I assume it does not really make a difference. Eg.

var $drop = $element.next().find('.chosen-drop');
$drop.css('position', 'static');
$element.trigger('dialogContentResize');
// Back to absolute.
$drop.css('position', '');
nagy.balint’s picture

nagy.balint commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3179785-9.patch960 bytes

The patch did not work for me on the top section of the dialog that is under the permission link of a views edit page.

What about the following patch?

nagy.balint’s picture

nagy.balint commented

Related issue #3327290: Claro views ui-dialog hides overflow

nagy.balint’s picture

nagy.balint commented

  • nagy.balint committed b24974b1 on 4.0.x 
    Issue #3179785 by silverham, nagy.balint, Nebel54, drupatz: Chosen...
nagy.balint’s picture

nagy.balint commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.