Problem/Motivation

References to \Drupal\Core\Routing\Enhancer\RouteEnhancerInterface need updated to \Drupal\Core\Routing\EnhancerInterface to be Drupal 9 compatible.

\Drupal\Core\Routing\Enhancer\RouteEnhancerInterface is deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0. Instead, you should use \Drupal\Core\Routing\EnhancerInterface. See https://www.drupal.org/node/2894934

Currently, src/Routing/VariantRouteFilter.php contains a reference to \Drupal\Core\Routing\Enhancer\RouteEnhancerInterface.

Proposed resolution

I will provide a patch to update the reference.

CommentFileSizeAuthor
#3 page_manager-route_enhancer-3179759-3.patch1.19 KBbdlangton
#2 page_manager-route_enhancer-3179759-2.patch652 bytesbdlangton

Comments

bdlangton created an issue. See original summary.

bdlangton’s picture

bdlangton commented
Status: Active » Needs review
StatusFileSize
new page_manager-route_enhancer-3179759-2.patch652 bytes
bdlangton’s picture

bdlangton commented
StatusFileSize
new page_manager-route_enhancer-3179759-3.patch1.19 KB

I apologize that I missed updating some code in the file. The code uses the applies() function which is only on RouteEnhancerInterface, not on EnhancerInterface. So I am removing that, but not sure if that is the best option.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs review » Reviewed & tested by the community
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Drupal 10 compatibility
andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Remove deprecated reference to RouteEnhancerInterface » [Drupal 9/10] Remove deprecated reference to RouteEnhancerInterface
Issue tags: +Drupal 9 compatibility

The interface was removed in 9.0 https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Routing%2...

andypost’s picture

andypost
he/him
Primary language Russian
commented
andypost’s picture

andypost
he/him
Primary language Russian
commented
Priority: Normal » Critical
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Since we aren't supporting before 9 on the 4.x this seems safe to remove, thanks for all your help

  • joelpittet committed 3efbe481 on 8.x-4.x 
    Issue #3179759 by bdlangton, andypost, tobiasb: [Drupal 9/10] Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.