So, signature checks are working most of the time, but let's look at my comment from #10

There's a couple which are using the SignatureValue property, and those are unpublished, so let's see if we can make that one work.

Original summary.

We currently don't check the signature on an incoming activity in the Inbox.

This is badly needed of course to make sure you don't get overspammed or spoofed.

(also, double check reply with peertube)

Comments

swentel created an issue. See original summary.

  • swentel committed c405174 on 1.0.x
    Issue #3179637: start checking the signature
    
swentel’s picture

Status: Active » Fixed

We'll probably need follow-ups to this one, but at least the status now depends on it.

swentel’s picture

Status: Fixed » Closed (fixed)
swentel’s picture

Status: Closed (fixed) » Needs work

Reopening, it doesn't work, most likely due to https://github.com/tootsuite/mastodon/issues/15016
Opened an issue at https://github.com/landrok/activitypub/issues/18 and will dig in deeper myself next week.

  • swentel committed 5928a4a on 1.0.x
    Issue #3179637: use libraries for verifying signature
    

  • swentel committed 05a33fa on 1.0.x
    Issue #3179637: refactor, removing keys service
    

  • swentel committed 728cc6c on 1.0.x
    Issue #3179637: add expclicit test
    
swentel’s picture

Priority: Critical » Normal
Status: Needs work » Active

The most important variation of the signature is now checked.

The other variation is (for DELETE requests for a user) where the value of the signature is in the payload itself.

swentel’s picture

With #3247999: phpsec needs some code updates in, most signatures are coming in fine, that's great.

There's a couple which are using the SignatureValue property, and those are unpublished, so let's see if we can make that one work.

swentel’s picture

Priority: Normal » Major
swentel’s picture

Issue summary: View changes
swentel’s picture

Issue summary: View changes
swentel’s picture

Status: Active » Fixed

I think this is fine at the moment. The SignatureValue is something that we can track in #3319596: Handle incoming delete actor requests

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

swentel’s picture

Status: Fixed » Closed (fixed)