Problem/Motivation

Following changes in commerce core with adding resolver API 3039854, this module needs to get an overall overhaul.

Proposed resolution

Split current option for resolving (store, cookie, language, geo) each into separate submodule. That way, people could use multiple resolvers.

Remove CommerceCurrencyResolversRefreshTrait, which most likely is not going to be needed.

Remove dependency on commerce_exchanger. Add that integration as a submodule as well.

Remaining tasks

User interface changes

API changes

CurrentCurrency is now resolver based on this patch 3039854

By default the main module follow patterns of current currency being resolved to current store.

Other methods of resolving - language, geo and cookie should be sub-modules with each having it's own resolver and potential mapping if applicable.

The fallback currency is now pulled from default store in the system.

Data model changes

TBD

Issue fork commerce_currency_resolver-3179459

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

valic created an issue. See original summary.

valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Issue summary: View changes
valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Priority: Normal » Major
valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Version: 8.x-1.x-dev » 2.0.x-dev

Change to go against new 2.0.x branch

valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Version: 2.0.x-dev » 2.x-dev

valic opened merge request !10

valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Issue summary: View changes
valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Issue summary: View changes
valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Category: Plan » Task
valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Status: Active » Reviewed & tested by the community

All the tests are green.

Made a change record draft as well

  • valic committed 9dfeba49 on 2.0.x 
    Resolve #3179459 "Version 2.x"
valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.