Problem/Motivation

We need to update dependencies prior to 9.1.x - this includes updating doctrine/common to be PHP 8 compatible.

Proposed resolution

Here are the updates...

+----------------------------------+---------+---------+
| Production Changes               | From    | To      |
+----------------------------------+---------+---------+
| doctrine/annotations             | 1.10.4  | 1.11.1  |
| doctrine/reflection              | 1.2.1   | 1.2.2   |
| symfony/console                  | v4.4.15 | v4.4.16 |
| symfony/debug                    | v4.4.15 | v4.4.16 |
| symfony/dependency-injection     | v4.4.15 | v4.4.16 |
| symfony/error-handler            | v4.4.15 | v4.4.16 |
| symfony/event-dispatcher         | v4.4.15 | v4.4.16 |
| symfony/http-foundation          | v4.4.15 | v4.4.16 |
| symfony/http-kernel              | v4.4.15 | v4.4.16 |
| symfony/mime                     | v5.1.7  | v5.1.8  |
| symfony/polyfill-ctype           | v1.18.1 | v1.20.0 |
| symfony/polyfill-iconv           | v1.18.1 | v1.20.0 |
| symfony/polyfill-intl-idn        | v1.18.1 | v1.20.0 |
| symfony/polyfill-intl-normalizer | v1.18.1 | v1.20.0 |
| symfony/polyfill-mbstring        | v1.18.1 | v1.20.0 |
| symfony/polyfill-php80           | v1.18.1 | v1.20.0 |
| symfony/process                  | v4.4.15 | v4.4.16 |
| symfony/routing                  | v4.4.15 | v4.4.16 |
| symfony/serializer               | v4.4.15 | v4.4.16 |
| symfony/translation              | v4.4.15 | v4.4.16 |
| symfony/validator                | v4.4.15 | v4.4.16 |
| symfony/var-dumper               | v5.1.7  | v5.1.8  |
| symfony/yaml                     | v4.4.15 | v4.4.16 |
| twig/twig                        | v2.13.1 | v2.14.1 |
+----------------------------------+---------+---------+

+---------------------------+---------+---------+
| Dev Changes               | From    | To      |
+---------------------------+---------+---------+
| composer/xdebug-handler   | 1.4.3   | 1.4.4   |
| squizlabs/php_codesniffer | 3.5.6   | 3.5.8   |
| symfony/browser-kit       | v4.4.15 | v4.4.16 |
| symfony/css-selector      | v4.4.15 | v4.4.16 |
| symfony/dom-crawler       | v4.4.15 | v4.4.16 |
| symfony/filesystem        | v4.4.15 | v4.4.16 |
| symfony/finder            | v4.4.15 | v4.4.16 |
| symfony/lock              | v4.4.15 | v4.4.16 |
| symfony/phpunit-bridge    | v5.1.7  | v5.1.8  |
+---------------------------+---------+---------+

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Updates doctrine/reflection to support PHP 8.

CommentFileSizeAuthor
#12 3179284-9.2.x-12.patch100.97 KBalexpott
#12 3179284-9.1.x-12.patch101.36 KBalexpott
#6 3179284-9.2.x-6.patch66.01 KBalexpott
#6 3179284-9.1.x-6.patch66.39 KBalexpott
#6 2-6-interdiff.txt2.08 KBalexpott
#2 3179284-9.2.x-2.patch63.93 KBalexpott
#2 3179284-9.1.x-2.patch64.32 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Status: Active » Needs review
Issue tags: +PHP 8.0
StatusFileSize
new 3179284-9.1.x-2.patch64.32 KB
new 3179284-9.2.x-2.patch63.93 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Parent issue: » #3109885: [meta] Ensure compatibility of Drupal 9 with PHP 8.0 (as it evolves)
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Patches look fine. I ran phpcs locally to check the upgrade doesn't affect us, no problems found. RTBC if test runs agree.

+++ b/composer.lock
@@ -7325,5 +7747,5 @@
-    "plugin-api-version": "1.1.0"
+    "plugin-api-version": "2.0.0"

Assume now that Composer 2.0 is out everyone should be using it to create composer.lock patches, otherwise we will have this and the "support" sections etc flipping in and out. Unsure if we have docs for this anywhere?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Update dependencies for Drupal 9.0 » Update dependencies for Drupal 9.1

Fix title ;)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2-6-interdiff.txt2.08 KB
new 3179284-9.1.x-6.patch66.39 KB
new 3179284-9.2.x-6.patch66.01 KB

Doctrine has changed an exception message we test. "accept" => "accepts"

andypost’s picture

andypost
he/him
Primary language Russian
commented

Patch will conflict with #3128631: Update dependencies composer/composer ^2 and composer/semver to ^3

But +1 to get it in as it the most hard dependency for PHP 8

The last submitted patch, 2: 3179284-9.2.x-2.patch, failed testing. View results

The last submitted patch, 2: 3179284-9.1.x-2.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Update dependencies for Drupal 9.1 » Update dependencies for Drupal 9.1 and 9.2

Both patches are green!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll +9.1.0 release notes
StatusFileSize
new 3179284-9.1.x-12.patch101.36 KB
new 3179284-9.2.x-12.patch100.97 KB

Rerolled... and there's been a Symfony release...

  • catch committed 94708f5 on 9.2.x 
    Issue #3179284 by alexpott, longwave, andypost: Update dependencies for...

  • catch committed bfb3afd on 9.1.x 
    Issue #3179284 by alexpott, longwave, andypost: Update dependencies for...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.