Problem/Motivation

It seems there are bad type hints in the class ContentEntityTrackingManager introduced in version 8.x-1.18.
It's using EntityTypeManager instead of EntityTypeManagerInterface and it conflicts with webprofiler's EntityManagerWrapper if installed.

Proposed resolution

Updating EntityTypeManager for EntityTypeManagerInterface in ContentEntityTrackingManager.

CommentFileSizeAuthor
#2 search_api-use-entity-type-manager-interface-790418-1.patch1.7 KBsebish

Comments

sebish created an issue. See original summary.

sebish’s picture

sebish commented
StatusFileSize
new search_api-use-entity-type-manager-interface-790418-1.patch1.7 KB

Here is a proposed patch.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 8.x-1.18 » 8.x-1.x-dev
Status: Active » Reviewed & tested by the community

Yes interface over concrete class for sure! Thanks @sebish

rhovland’s picture

rhovland
he/him
Primary language English
Location Oregon
commented

Thanks for the patch. Fixes webprofiler breaking our site in dev environments.

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented

#2 works. I was about to open the same issue with the same patch :)

esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented

I can confirm the issue is easily replicated by enabling search_api and webprofiler and the patch solved it.

kevinfunk’s picture

kevinfunk
he/him
commented

I'll also confirm that #2 fixed my issue with Webprofiler.

floydm’s picture

floydm commented

Also confirming that I got this error after enabling webprofiler and that patch #2 fixed it.

yogesh kushwaha’s picture

yogesh kushwaha commented

#2 works for me as well. I had this error while enabling the webprofiler module similar to #7 and #8.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot for reporting and providing a patch! You’re right, using a class instead of the interface is just wrong there – seems I overlooked this during review. (That was a very complex issue to review, as a small excuse.)
Anyways, committed. Thanks again!

  • drunken monkey committed 40992b7 on 8.x-1.x authored by sebish 
    Issue #3179045 by sebish, joelpittet, drunken monkey: Fixed parameter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.